Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pdf engine #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

4brunu
Copy link

@4brunu 4brunu commented Jun 18, 2024

The PdfEngine class is not used, so it can be removed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to this project. This is your first pull request and we are so glad to have you onboard. We will review the request and get back to you soon. We love your contributions! Join our Discord community here to discuss this PR or ask questions.

@4brunu
Copy link
Author

4brunu commented Jun 28, 2024

@afreakyelf Hi, could you please take a look at this? Thanks

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jul 29, 2024
@4brunu
Copy link
Author

4brunu commented Jul 29, 2024

Any news on this?

@github-actions github-actions bot removed the Stale label Jul 30, 2024
Copy link
Owner

@afreakyelf afreakyelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was cleary an oversight at my end.

@foodpoison
Copy link

Will these approved PRs be merged? @afreakyelf ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants