Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer: missing functionality #183

Open
3 of 4 tasks
berenddeboer opened this issue Apr 17, 2019 · 2 comments
Open
3 of 4 tasks

Drawer: missing functionality #183

berenddeboer opened this issue Apr 17, 2019 · 2 comments

Comments

@berenddeboer
Copy link
Collaborator

berenddeboer commented Apr 17, 2019

  • Drawer has subscriptions but does not appear to use them, can this code be removed?
  • Drawer list: support arrow keys. This will probably be fixed when lists get keyboard control, and we can then use the list inside here.
  • Dismissible and modal drawers: support Esc to close
  • Dismissible drawer: open animation is off: the content should slide in from the left.
@berenddeboer
Copy link
Collaborator Author

The issue with the dismissible drawer seems to be that the "endtransition" event fires early, perhaps related to some transition we do in the list? The evt.target.className is "mdc-list-item mdc-list-item--activated mdc-ripple-upgraded mdc-ripple-upgraded--background-focused", so that's quite wrong.

So the animation is ended prematurely, and the aside doesn't slide in properly.

@berenddeboer
Copy link
Collaborator Author

A cheap way to fix this is to set Lists.nonInteractive when the drawer is not yet fully open. However, that requires work from the user, this is something we need to handle transparently. Not sure how the MDC does this yet, they would have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant