Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enforce scope in commit title #325

Closed
kowalczykp opened this issue Nov 20, 2020 · 4 comments · Fixed by #342
Closed

Option to enforce scope in commit title #325

kowalczykp opened this issue Nov 20, 2020 · 4 comments · Fixed by #342

Comments

@kowalczykp
Copy link
Contributor

Slightly related to #213

It'd be great if commitsar could enforce the existence of the scope part in the commit title. The scope is considered optional by the conventional commits spec, but that feature would be very beneficial to repositories requiring stricter checks. The next step could potentially be, restricting the allowed scopes to a configurable list.

Let me know, if that makes sense and if you'd be interested in such a feature. I'd be happy to PR it.

@fallion
Copy link
Member

fallion commented Nov 30, 2020

I think this could be a cool addition to the configuration file. Feel free to open a PR :) I am in the process of reworking the flow a little so if you could wait until Wednesday then that would be great :)

@fallion
Copy link
Member

fallion commented Dec 2, 2020

All yours :)

@fallion
Copy link
Member

fallion commented Jan 19, 2021

@kowalczykp hey,

Have you had a chance to look at this?

@kowalczykp
Copy link
Contributor Author

kowalczykp commented Jan 21, 2021

hey @fallion, sorry for the late answer. I've sat down to this today, and have a working code ready. I will add some tests, clean up the code, and will create PR later today, once I'm back with some points to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants