This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
docs: Cordova code samples reflecting aerogear-js-sdk changes in API #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwright
approved these changes
Feb 6, 2019
wtrocki
reviewed
Feb 18, 2019
| @@ -15,5 +15,5 @@ const aerogearConfig = { | |||
| // Replace with your own configuration | |||
| }; | |||
|
|
|||
| init(aerogearConfig); | |||
There was a problem hiding this comment.
IMHO this is just showing that our flow and documentation snippets are really confusing. It's almost impossible to find that info (and I know about it). Documentation for this part should be included in each individual SDK so I do not need to jump and find how to configure things. Adding as placeholder for myself to improve stuff afetr.
There was a problem hiding this comment.
@wtrocki yes, you're right ;)
we should revisit this change
There was a problem hiding this comment.
Agree this needs to be called out in each as our documentation flow doesn't ever get to this point see #654
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://issues.jboss.org/browse/AEROGEAR-8462
What
Changed code samples.
Why
Code samples reflect changes from 2.1.0-rc3 aerogear-js-sdk
How
Changing code samples in Cordova
Verification Steps
Check all Cordova code samples.
Checklist:
Progress