Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet is too mixed one #8

Open
acktsap opened this issue Jul 4, 2019 · 0 comments
Open

Wallet is too mixed one #8

acktsap opened this issue Jul 4, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@acktsap
Copy link
Contributor

acktsap commented Jul 4, 2019

Wallet should have a single role, but it extends too many interfaces. I think we have to split key managing with client.

It's hard to remove it in 1.x. Maybe it should be remove in 2.x. But until then, it's good to introduce fine-grained api for alternatives. And in 2.x, introduce new coarse-grained api as an alternative to current Wallet interface.

Fine-grained apis should have following roles

  • KeyManaging (abstraction for interaction with java keystore or server keystore)
  • Nonce handling
  • ChainIdHash handling
  • Failover handling

Before that, we have to refactor context to handle failover elegantly.
@acktsap acktsap added the enhancement New feature or request label Jul 4, 2019
@acktsap acktsap changed the title Wallet is too mixed Wallet is too mixed one Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acktsap