Fix decorator types #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various TS1270 and TS1238 issues are not resolved. However, this comes at the cost of decorators and result types not being "well-typed". Hopefully TypeScript can soon produce their own version such that these can be replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR resolves various TS1270 and TS1238 issues when applying decorator or decorator result types. Sadly, these do not offer "well-typed" decorators, which seems to be very difficult (if not impossible) for now.
Hopefully, in a future version of TypeScript, decorator functions and return types are offered as "native" types. But, for now these will have to do.