Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Tiled exports only to Components and Resources #50

Closed
adrien-bon opened this issue Nov 15, 2024 · 0 comments · Fixed by #58
Closed

Restrict Tiled exports only to Components and Resources #50

adrien-bon opened this issue Nov 15, 2024 · 0 comments · Fixed by #58
Labels
enhancement New feature or request

Comments

@adrien-bon
Copy link
Owner

Currently, we export all types that have been registered in bevy_reflect.
While it works, this is sub-optimal: in the end, we are only interested in the types we will be actually able to use, ie. Components and Resources. It leads to a lot of clutter in the TIled interface.

A solution to this would be to only register types that either:

  • derive ReflectComponent or ReflectBundle trait
  • derive ReflectResource trait
  • are used by a type which derive one of these traits (this is actually the hard part)
@adrien-bon adrien-bon added the enhancement New feature or request label Nov 15, 2024
@adrien-bon adrien-bon linked a pull request Dec 10, 2024 that will close this issue
Handle non-unit enums #58
Merged
adrien-bon added a commit that referenced this issue Dec 14, 2024
@adrien-bon @Niashi24
Handle non-unit enums (#58)
9fe428e 
*  Restrict Tiled exports only to Components and Resources #50 

*  Support non-unit enums user properties #49 

* fix: prevent infinite loop in case an asset fails to load

* feat: improve how we handle default values for user properties

---------

Co-authored-by: Niashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle non-unit enums adrien-bon/bevy_ecs_tiled
1 participant
@adrien-bon