Refactor: Improve Readability and Maintainability with Explaining Variables, Renaming, and Polymorphism

[Saikat-Raj]

This pull request introduces several refactorings to enhance code readability, reduce duplication, and improve maintainability. The following changes have been made:

Introducing Explaining Variable (useHttpProtocol):
A new variable is introduced to replace an ambiguous conditional check, improving the clarity of the condition and making the code more self-explanatory.

Renaming credentials() to getCredentials():
The credentials() function has been renamed to getCredentials() to better reflect its purpose, enhancing the readability of the code.

Applying Polymorphism in DFSPrivateKeyServiceImpl:
A KeyType hierarchy has been introduced to abstract key types and their corresponding prefixes.
Conditional logic in the getKeyByPrefix method has been replaced with polymorphism, simplifying the code and improving maintainability.

Moving getStorageAccessCredentials to a Dedicated Helper Method:
The logic for retrieving storage access credentials has been encapsulated into a dedicated helper method, improving code clarity and separation of concerns.

Extracting CacheCreator Class for Cache Logic:
The cache creation logic has been extracted into a new CacheCreator class, organizing the code better by separating the cache handling responsibilities.

Extracting createCache Method to Avoid Duplication:
A new utility method, createCache, has been introduced to eliminate the duplication in cache creation logic. This improves maintainability and readability.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud