Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Error - Failed to install modules #392

Closed
yashodhah opened this issue May 9, 2019 · 7 comments
Closed

Install Error - Failed to install modules #392

yashodhah opened this issue May 9, 2019 · 7 comments

Comments

@yashodhah
Copy link

OS : Windows 7
Node version : 6.9.2
Ember-cli :3.3

ember install ember-electron

npm: Installed ember-electron
installing ember-electron
  create ember-electron\.compilerc
  create ember-electron\main.js
  create ember-electron\test-main.js
  create testem-electron.js
Project needs forge config
Failed to install modules: ["[email protected]"]

With output: Exited with status 1

@jacobq
Copy link
Collaborator

jacobq commented May 9, 2019

Hmm, there is no "[email protected]" published on NPM (see lament electron-userland/electron-prebuilt-compile#77)

I just ran ember install ember-electron on an empty/new ember project on Windows, and it works fine. Could you please share your package.json file? (Or at least the deps/devDeps entries for packages with electron in their names)

ember-cli: 3.9.0
node: 12.1.0
os: win32 x64

@yashodhah
Copy link
Author

yashodhah commented May 10, 2019

Excerpt from package.json
{
  "name": "test",
  "version": "0.0.0",
  "private": true,
  "description": "test",
  "license": "",
  "author": "",
  "directories": {
    "doc": "doc",
    "test": "tests"
  },
  "repository": "",
  "scripts": {
    "build": "ember build",
    "start": "ember serve",
    "test": "ember test"
  },
  "devDependencies": {
    "broccoli-asset-rev": "^2.7.0",
    "broccoli-concat": "^3.2.2",
    "broccoli-uglify-js": "^0.2.0",
    "datasaur-sorter": "^1.0.0",
    "ember-ajax": "^3.0.0",
    "ember-browserify": "^1.2.0",
    "ember-cli": "3.3.0",
    "ember-cli-app-version": "^3.0.0",
    "ember-cli-babel": "^6.6.0",
    "ember-cli-bootstrap-datepicker": "^0.6.1",
    "ember-cli-dependency-checker": "^2.0.0",
    "ember-cli-eslint": "^4.2.1",
    "ember-cli-htmlbars": "^2.0.1",
    "ember-cli-htmlbars-inline-precompile": "^1.0.0",
    "ember-cli-inject-live-reload": "^1.4.1",
    "ember-cli-qunit": "^4.3.2",
    "ember-cli-sass": "5.2.0",
    "ember-cli-shims": "^1.2.0",
    "ember-cli-sri": "^2.1.0",
    "ember-cli-uglify": "^2.0.0",
    "ember-export-application-global": "^2.0.0",
    "ember-load-initializers": "^1.1.0",
    "ember-maybe-import-regenerator": "^0.1.6",
    "ember-resolver": "^4.0.0",
    "ember-source": "3.3.0",
    "eslint-plugin-ember": "^5.0.0",
    "filepath": "^1.1.0",
    "fin-hypergrid": "file:./lib/hypergrid/core-3.0.3",
    "fin-hypergrid-grouped-header-plugin": "1.2.4",
    "datasaur-filter": "file:./lib/hypergrid/datasaur-filter-sort-custom-3.0.0",
    "datasaur-indexed": "file:./lib/hypergrid/datasaur-indexed-custom",
    "loader.js": "^4.2.3",
    "qunit-dom": "^0.6.2"
  },
  "engines": {
    "node": "6.* || 8.* || >= `10.*"`
  }
}

@jacobq
Copy link
Collaborator

jacobq commented May 10, 2019

I tried to reproduce this again using node 6.x and ember-cli 3.3 but so far have not been able to. I think it is happening because electron-forge is attempting to use the version number associated with the latest electron release (5.0.1) with the electron-prebuilt-compile package, which is behind.
(See https://github.com/electron-userland/electron-forge/blob/5.x/src/api/import.js#L178-L180)

Could you enable debugging, try again, and post the log here?
DEBUG=electron-forge:*,ember-electron:* ember install ember-electron

When I do it on a fresh project I see a line like this:

electron-forge:dependency-installer installing ["electron-prebuilt-compile@latest"] in: C:\path\ee-test dev=true,exact=true,withYarn=true

but I suspect you'll see [email protected], which is why it's failing in your case.

@PavloNaumenko
Copy link

@jacobq I have the same issue. It looks like changes from the master branch haven't been published to the npm (with a new tag).

@YD1722 You can make changes in package.json till the project maintainers don't publish it :
"ember-electron": "https://github.com/adopted-ember-addons/ember-electron.git",

@jacobq
Copy link
Collaborator

jacobq commented May 10, 2019

It looks like changes from the master branch haven't been published to the npm (with a new tag).

Yes, and sorry for inconvenience. We're in the process of changing maintainers. However, I'm still puzzled as to why the problem is happening / what changes in master fix it. @PavloNaumenko could you share some debug output? Is it because of older electron-forge? If so, why can't I reproduce it? Lockfile issue?

@PavloNaumenko
Copy link

@jacobq Hm, I can't reproduce it again. Maybe it was an npm cache?

@bendemboski
Copy link
Member

This appears to be resolved, so I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants