From 07d5989010682c73a273de6c4962699c846a816a Mon Sep 17 00:00:00 2001 From: Christian Date: Fri, 28 Dec 2018 16:27:04 +0100 Subject: [PATCH] fix: apply included function with arguments instead of app This is the "recommended" way as seen in https://ember-cli.com/extending/#addon-entry-point . I'm opening this PR as `this._super.included(app)` it causes some issues with ember-decorators and the next ember-cli-typescript version. This will prevent others from having to dive in on why this happens if you try to port your addon to use these addons. --- index.js | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/index.js b/index.js index 1bd01824..b844e29d 100644 --- a/index.js +++ b/index.js @@ -16,7 +16,7 @@ module.exports = { name: 'ember-electron', included(app) { - this._super.included(app); + this._super.included.apply(this, arguments); if (!process.env.EMBER_CLI_ELECTRON) { return; diff --git a/package.json b/package.json index 293954dd..218ffc3f 100644 --- a/package.json +++ b/package.json @@ -66,7 +66,6 @@ "file-url": "^2.0.2", "fs-extra": "^2.0.0", "globby": "^6.0.0", - "loader.js": "^4.2.3", "lodash": "^4.15.0", "quick-temp": "^0.1.5", "rimraf": "^2.6.1", @@ -112,6 +111,7 @@ "eslint-plugin-ember": "^5.0.0", "eslint-plugin-ember-suave": "^1.0.0", "eslint-plugin-node": "^6.0.1", + "loader.js": "^4.2.3", "mocha": "^3.5.3", "mock-spawn": "^0.2.6", "mockery": "^1.4.0",