refactor: update ready message #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Should we rename |
I thought that too. But in fact, is there really still a use case or a specific moment when we're going to prefer --watch mode to --hmr? I don't think so at the moment. o maybe |
--throw-deprecation will cause the test to fail since we are using ts-node, and ts-node use features that are deprecated with node 22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
file system watchermessage that appears when you start the Adonis server is no longer really appropriate now that we have HMR. Because we have aFile System Watcher: disabledwhich is displayed when we are in HMR mode.Looks weird
So I've changed the message. But not really sure of the words :
Mode: Non-Watching.--watchwill display:Mode: Watching--hmrwill display:Mode: HMRif you guys have something better lemme know