Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate (or auto-update) Github URL to be correct when adding or updating sites #255

Open
iuliag opened this issue Apr 3, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers tech debt Technical Debt

Comments

@iuliag
Copy link
Contributor

iuliag commented Apr 3, 2024

Description
Some sites have been added to SpaceCat with a (now, after the sites moved outside of the hlxsites Github org) invalid Github URL.

To Reproduce
Steps to reproduce the behavior:

  1. Add a new site and set the githubURL to "https://example.com"

Expected behavior
Ideally the github URL for a sites would be updated automatically from an external system that provides the correct URL (e.g. based on Helix 5 config).
If any audit needs to be developed based on Github URLs, then the API/data layer needs to validate:

@iuliag iuliag added bug Something isn't working good first issue Good for newcomers tech debt Technical Debt labels Apr 3, 2024
@iuliag
Copy link
Contributor Author

iuliag commented Apr 8, 2024

@solaris007 any opinions on this or is this something you'd like to include in your list for next week?

@solaris007
Copy link
Member

@iuliag currently there's no deterministic way to match a production baseURL as identified via site discovery to a github repo. We'll discuss it at the helix hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers tech debt Technical Debt
Projects
None yet
Development

No branches or pull requests

2 participants