Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If domainkey is wrong can we provide a non-authorized response body? #912

Open
MarquiseRosier opened this issue Jul 13, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@MarquiseRosier
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
currently if domain key is wrong; here's what we return,
Screen Shot 2023-07-13 at 9 09 11 AM

Describe the solution you'd like
if we can give a 401 status code vs a response with a data field in the body of the response, this would be more helpful for consumers of the api!

issue raised by David Barrat of the DAAS team

@MarquiseRosier MarquiseRosier added the enhancement New feature or request label Jul 13, 2023
@MarquiseRosier MarquiseRosier self-assigned this Jul 13, 2023
@dbrrt
Copy link
Collaborator

dbrrt commented Jul 14, 2023

@MarquiseRosier Another note on the domainKey. It'd be a better practice to have it in the headers rather than as a query parameter since as a query parameters, it'll be visible in the query logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants