New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart crop Assets block powered by DMwOA #11

Open

anuraggupta228 wants to merge 1 commit into main from 10-smartcrop-asset

Contributor

anuraggupta228 commented Nov 26, 2024

Fixes : https://github.com/adobe-rnd/aem-assets-plugin/issues

Demo pages:


          Smart crop Assets block powered by DMwOA

f497b78

anuraggupta228 requested a review from sdmcraft

November 26, 2024 17:29

anuraggupta228 linked an issue

that may be closed by this pull request

Smart Crop Assets with DM OpenAPI #10

Open

Collaborator

sdmcraft commented Nov 29, 2024

I think we can directly use the srcset functionality of the picture which serves the exact purpose natively. For e.g.

<picture>
  <source srcset="image.jpg?smartcrop=large" media="(min-width: 1024px)">
  <source srcset="image.jpg?smartcrop=medium" media="(min-width: 768px)">
  <source srcset="image.jpg?smartcrop=small">
  <img src="image.jpg" alt="A responsive example">
</picture>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet