Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matching Strategy how to deal with supplementalSemanticID #479

Open
J-Blume opened this issue Oct 30, 2024 · 2 comments · Fixed by #482
Open

Add Matching Strategy how to deal with supplementalSemanticID #479

J-Blume opened this issue Oct 30, 2024 · 2 comments · Fixed by #482
Labels
accepted accepted in principle to be fixed documentation Improvements or additions to documentation
Milestone

Comments

@J-Blume
Copy link

J-Blume commented Oct 30, 2024

Is your feature request related to a problem? Please describe.
At the moment it is not described how to handle supplementalSemanticID for the matching of SemanticIDs

@BirgitBoss BirgitBoss added the requires workstream approval strategic decision proposal needs to be prepared in TF spec team label Oct 30, 2024
@BirgitBoss
Copy link
Collaborator

2024-10-30 TF AAS Metamodel

Add to Intelligent matching a new group

Consider Supplemental SemanticId
Strategy 1: Consider semanticId and supplementatld as a single set of semanticIds
• Input: set of semanticIds (not distinguishing between semanticId and supplementalIds)
• Index of supplemantalId is not relevant. SupplematlSemanticId is an unordered list.
• Match required that all semanticIds in Input are either in semanticId or in supplementalSemanticIds
• Include supplemental semanticId when looking for a semanticId that should match. This can be combined with exact or value matching.
• Example: semanticId xxx would match to supplementalds[3] = xxx
• Example: semanticId = xx and supplementatlId[{index}] =yyy does not match semanticId =xx without supplementatIds[{index}] = yy
• Example: semanticId = xx and supplementatlId[1] =yyy matches semanticId =xx with supplementatIds[3] = yy
• Example: Input: {semanticId xxx, semantic yyyy} would not match to semanticId = zzz and supplementalds[3] = xxx

Strategy 2: Consider semanticId and supplementatld as a single set of semanticIds
• Input: set of semanticIds (not distinguishing between semanticId and supplementalIds)
• Index of supplemantalId is not relevant. SupplematlSemanticId is an unordered list.
• Match required that at least one of the semanticIds in Input are either in semanticId or in supplementalSemanticIds
• Include supplemental semanticId when looking for a semanticId that should match. This can be combined with exact or value matching.
• Example: semanticId xxx would match to supplementalds[3] = xxx
• Example: Input: {semanticId xxx, semantic yyyy} would match to supplementalds[3] = xxx

Consider isCaseOf of referenced semanticId
Strategy 1: extend set semanticIds of Consider Supplemental SemanticId to also include isCaseOf
Strategy 2: Input semanticId Consider also isCaseOf
Example: semanticId = xx matches to semanticId = yy with CD/id = yy and CD/isCaseOf = xx

@BirgitBoss BirgitBoss added ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream and removed requires workstream approval strategic decision proposal needs to be prepared in TF spec team labels Oct 30, 2024
@BirgitBoss BirgitBoss added this to the V3.1 milestone Oct 30, 2024
@BirgitBoss BirgitBoss changed the title Add Matchingstrategy how to deal with supplementalSemanticID Add Matching Strategy how to deal with supplementalSemanticID Oct 31, 2024
@BirgitBoss BirgitBoss added accepted accepted in principle to be fixed and removed ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream labels Nov 14, 2024
@BirgitBoss
Copy link
Collaborator

2024-11-11 Workstream AAS Specs
Decision Proposal accepted #479 (comment)

@BirgitBoss BirgitBoss added the documentation Improvements or additions to documentation label Nov 15, 2024
@BirgitBoss BirgitBoss linked a pull request Dec 12, 2024 that will close this issue
BirgitBoss added a commit that referenced this issue Dec 13, 2024
* fix formatting

* #480 add example with referredSemanticId

* extension of #480: added invalid examples for all constraints for References

* closes #471 different syntax intelligent matching

* closes #473 Matching semanticId
value-match and exact match

* closes #479 supplementalSemanticId and isCaseOf

* see #479 now isCaseOf included in strategy

* add note that implementations may differ

Co-authored-by: s-heppner <[email protected]>

* grammar

* fix typo

Co-authored-by: s-heppner <[email protected]>

* exact match for semanticIc
+ formatting

---------

Co-authored-by: s-heppner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted in principle to be fixed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants