diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index e6e1f33..8ecfc02 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -20,7 +20,7 @@ jobs: - name: Run build run: | - make up push + make up - name: Run tests run: | diff --git a/Makefile b/Makefile index 592979c..47b60f4 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,10 @@ .DEFAULT_GOAL := help +CACHE_IMG = "ghcr.io/adfinis/pyaptly/cache:latest" + +DOCKER_BUILDKIT = 1 +export DOCKER_BUILDKIT + # Help target extracts the double-hash comments from the targets and shows them # in a convenient way. This allows us to easily document the user-facing Make # targets @@ -7,14 +12,30 @@ help: @grep -E '^[a-zA-Z0-9_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort -k 1,1 | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' +.PHONY: pull +pull: ## pull cached container + @docker pull $(CACHE_IMG) + +.PHONY: build +build: pull ## build the container if needed (cached) + # I know about --cache-from type=registry,ref= but it does not work on github actions + # and I want local and github to be the same, so we do a pull. + @env | grep DOCKER + docker build \ + --build-arg BUILDKIT_INLINE_CACHE=1 \ + -t $(CACHE_IMG) compose + +.PHONY: build +build-force: ## build the container (not cached) + @docker buildx build --cache-to type=inline -t $(CACHE_IMG) compose + .PHONY: up -up: ## start and build container if needed - #@docker pull ghcr.io/adfinis/pyaptly/cache:latest - @DOCKER_BUILDKIT=1 docker compose up -d --build +up: build ## start the container + @docker compose up -d .PHONY: push push: ## push docker build cache to registry - @docker push ghcr.io/adfinis/pyaptly/cache:latest + @docker push $(CACHE_IMG) .PHONY: down down: ## stop and remove container diff --git a/compose/Dockerfile b/compose/Dockerfile index 9b20f4d..bf18a8d 100644 --- a/compose/Dockerfile +++ b/compose/Dockerfile @@ -1,5 +1,4 @@ -ARG DOCKER_IMAGE -FROM $DOCKER_IMAGE +FROM debian:bookworm-slim RUN apt-get update && apt-get install -y --no-install-recommends \ python3-toml \ @@ -32,4 +31,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ ADD setup /setup RUN /setup/setup ADD run /setup/run -ENTRYPOINT ["/usr/bin/tini", "--"] \ No newline at end of file +WORKDIR /source +ENTRYPOINT ["/usr/bin/tini", "--"] +CMD ["bash", "/setup/run"] \ No newline at end of file diff --git a/docker-compose.yml b/docker-compose.yml index e90c033..72fe5cf 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -2,14 +2,5 @@ services: testing: image: ghcr.io/adfinis/pyaptly/cache:latest - build: - cache_from: - - ghcr.io/adfinis/pyaptly/cache:latest - context: compose - args: - BUILDKIT_INLINE_CACHE: 1 - DOCKER_IMAGE: debian:bookworm-slim - working_dir: /source - command: ["bash", "/setup/run"] volumes: - ./:/source