Promise.js naming collision

[parmarnishant]

Error building DependencyGraph:
Error: Naming collision detected: <>/node_modules/react-native-simple-auth/node_modules/react-native/Libraries/Promise.js collides with <>/node_modules/react-native/Libraries/Promise.js
Promise.js naming collision

[adamjmcgrath]

/node_modules/react-native-simple-auth/node_modules/react-native/Libraries/Promise.js

#24 should fix this - delete your node_modules directory and install the latest version

[davidchang]

@adamjmcgrath, could you make another release in npm? Last release (0.2.8) appears to be from August and, unless I'm mistaken, doesn't automatically pick up #24

[spacesuitdiver]

I can confirm this isn't in npm yet. Would be great to see an update.

[adamjmcgrath]

Sorry - been on holiday, 0.2.9 released

[spacesuitdiver]

Thanks! @adamjmcgrath what's the status of SimpleAuth as an iOS library you think? I couldn't get it to work even using your fork to fix the FB field issue.

[adamjmcgrath]

Np - not sure about SimpleAuth. Think it had some issues with Xcode 7. I'll see if I can get it running locally in the next couple of days

[spacesuitdiver]

@adamjmcgrath You mentioned the field issues here, just curious why it hasn't been merged into the repo calebd/SimpleAuth#109 hence my curiosity of it's status. I've never used this library though so I'm not sure what to expect. In general should this thing pop a webview/svc/etc. for each auth provider?

[adamjmcgrath]

just curious why it hasn't been merged into the repo calebd/SimpleAuth#109 hence my curiosity of it's status

No idea why calebd/SimpleAuth#109 hasn't been merged - there hasn't been a lot of activity on that repo and I haven't really pushed it as I use an old Facebook API key that still uses a compatible version of the Graph API

I've never used this library though so I'm not sure what to expect. In general should this thing pop a webview/svc/etc. for each auth provider?

Each provider is different, for example Facebook uses iOS Social framework, FacebookWeb pops a WebView, and there's a PR to add Facebook SDK login calebd/SimpleAuth/pull/44

[davidchang]

@adamjmcgrath sorry for late response, many many thanks for updating to 0.2.9. npm installed and everything worked seamlessly.

[spacesuitdiver]

Okay. Honestly I got Facebook SDK working already (which uses like 3 different methods depending on availability) but was interested in this for the Twitter and Instagram (or to do all the things would be nice).

Any thoughts on a viable solution for all forms of social auth?

On Dec 21, 2015, at 5:57 PM, Adam Mcgrath [email protected] wrote:

just curious why it hasn't been merged into the repo calebd/SimpleAuth#109 hence my curiosity of it's status

No idea why calebd/SimpleAuth#109 hasn't been merged - there hasn't been a lot of activity on that repo and I haven't really pushed it as I use an old Facebook API key that still uses a compatible version of the Graph API

I've never used this library though so I'm not sure what to expect. In general should this thing pop a webview/svc/etc. for each auth provider?

Each provider is different, for example Facebook uses iOS Social framework, FacebookWeb pops a WebView, and there's a PR to add Facebook SDK login calebd/SimpleAuth#44

—
Reply to this email directly or view it on GitHub.

[adamjmcgrath]

but was interested in this for the Twitter and Instagram (or to do all the things would be nice)
Any thoughts on a viable solution for all forms of social auth?

SimpleAuth supports Twitter and Instagram, and lots of other social auth providers

SimpleAuth has Twitter support for iOS Social framework ("Twitter") and WebView ("TwitterWeb"), so you could create a solution that falls back to WebView if iOS Social framework is not available, something like

simpleAuthClient.authorize('twitter').then((info) => {
  let token = info.token;
  let name = info.name;
}).catch((error) => {
  simpleAuthClient.authorize('twitterWeb').then((info) => {
    let token = info.token;
    let name = info.name;
  })
});

SimpleAuth only has support for Instagram via a WebView.