-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gamma correction seems wrong #27
Comments
@PaintYourDragon any thoughts? |
It's an interesting issue, that would need to be studied. At first, we must know what's the OETF (opto electronic transfer function) of a LED, from what I read, brightness is linear with current (here we're driving LED with voltage). Note that I'm not using the term "gamma", it's a too much global actually and means nothing. |
In an RGB led datasheet (https://www.arduino.cc/documents/datasheets/LEDRGB-L-154A4SURK.pdf), we can see the current/voltage transfer curve. Search for the forward current vs. forward voltage chart. |
The gamma correction calculation formula in colorview.ino seems not right.
`for (int i=0; i<256; i++) {
`
I think it should be x = pow(x, 2.5); --> x = pow(x, 1/2.5);
The text was updated successfully, but these errors were encountered: