add basic loop() test #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
approved these changes
Jul 28, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 28, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.0.0 from 2.28.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#191 from FoamyGuy/blit_refactor Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.4.1 from 7.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#172 from vladak/test_loop Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.11 from 0.7.10: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#58 from jepler/fix-example-pio-kwargs Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since finishing PR #169, I have been thinking about at least simple test for the loop() return semantics. Here it is.
There is some room for improvement (like always). Specifically, there are other aspects of the function that could be tested (such as MQTT ping) and also if loop() was not cooperating (by returning within some time), the test would be hosed.