Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the workaround for buggy recv_into() #157

Open
vladak opened this issue Feb 21, 2023 · 3 comments
Open

remove the workaround for buggy recv_into() #157

vladak opened this issue Feb 21, 2023 · 3 comments
Labels
bug Something isn't working waiting-for-new-circuitpython-release

Comments

@vladak
Copy link
Contributor

vladak commented Feb 21, 2023

The \x00 literal should be removed

Adafruit_CircuitPython_MiniMQTT/adafruit_minimqtt/adafruit_minimqtt.py

Line 984 in 342b8c9

if res in [None, b"", b"\x00"]:
once adafruit/circuitpython#7606 is fixed.
@vladak
Copy link
Contributor Author

vladak commented Mar 7, 2023

This should probably wait for some time for the CP versions with the fix to percolate to the wide public. This could take a long time, I think.

@brentru brentru added the bug Something isn't working label Apr 11, 2023
@brentru
Copy link
Member

brentru commented Apr 11, 2023

Both of these were added to CircuitPython as of 8.1.0 beta 1, let's keep this code in until 8.1.0 is stable and released.

@vladak
Copy link
Contributor Author

vladak commented May 31, 2023

8.1.0 has been stable as of last week it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working waiting-for-new-circuitpython-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brentru @vladak