From 4c048acdebfc074f95028c4a305ef2598b76e431 Mon Sep 17 00:00:00 2001 From: ylz Date: Mon, 27 Nov 2023 11:18:18 +0800 Subject: [PATCH] optimize log display inner 2378 fix --- .../backend/datasource/PhysicalDbGroup.java | 6 +++--- .../backend/delyDetection/DelayDetection.java | 6 +++--- .../dble/backend/heartbeat/MySQLDetector.java | 2 +- .../backend/heartbeat/MySQLHeartbeat.java | 20 +++++++++---------- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/main/java/com/actiontech/dble/backend/datasource/PhysicalDbGroup.java b/src/main/java/com/actiontech/dble/backend/datasource/PhysicalDbGroup.java index 24d0cd5510..b01c8440bf 100644 --- a/src/main/java/com/actiontech/dble/backend/datasource/PhysicalDbGroup.java +++ b/src/main/java/com/actiontech/dble/backend/datasource/PhysicalDbGroup.java @@ -685,7 +685,7 @@ public boolean checkInstanceExist(String instanceName) { private void reportDisableError(PhysicalDbInstance ins) throws IOException { final DbInstanceConfig config = ins.getConfig(); - String disableError = "the dbInstance[" + config.getUrl() + "] is disable. Please check the dbInstance disable status"; + String disableError = "the dbInstance[" + dbGroupConfig.getName() + ":" + config.getInstanceName() + ":" + config.getUrl() + "] is disable. Please check the dbInstance disable status"; LOGGER.warn(disableError); Map labels = AlertUtil.genSingleLabel("dbInstance", dbGroupConfig.getName() + "-" + config.getInstanceName()); AlertUtil.alert(AlarmCode.DB_INSTANCE_CAN_NOT_REACH, Alert.AlertLevel.WARN, disableError, "mysql", config.getId(), labels); @@ -694,7 +694,7 @@ private void reportDisableError(PhysicalDbInstance ins) throws IOException { private void reportFakeNodeError(PhysicalDbInstance ins) throws IOException { final DbInstanceConfig config = ins.getConfig(); - String fakeNodeError = "the dbInstance[" + config.getUrl() + "] is fake node. Please check the dbInstance whether or not it is used"; + String fakeNodeError = "the dbInstance[" + dbGroupConfig.getName() + ":" + config.getInstanceName() + ":" + config.getUrl() + "] is fake node. Please check the dbInstance whether or not it is used"; LOGGER.warn(fakeNodeError); Map labels = AlertUtil.genSingleLabel("dbInstance", dbGroupConfig.getName() + "-" + config.getInstanceName()); AlertUtil.alert(AlarmCode.DB_INSTANCE_CAN_NOT_REACH, Alert.AlertLevel.WARN, fakeNodeError, "mysql", config.getId(), labels); @@ -703,7 +703,7 @@ private void reportFakeNodeError(PhysicalDbInstance ins) throws IOException { private void reportHeartbeatError(PhysicalDbInstance ins) throws IOException { final DbInstanceConfig config = ins.getConfig(); - String heartbeatError = "the dbInstance[" + config.getUrl() + "] can't reach. Please check the dbInstance is accessible"; + String heartbeatError = "the dbInstance[" + dbGroupConfig.getName() + ":" + config.getInstanceName() + ":" + config.getUrl() + "] can't reach. Please check the dbInstance is accessible"; if (dbGroupConfig.isShowSlaveSql()) { heartbeatError += " and the privileges of user is sufficient (NOTE:heartbeat[show slave status] need grant the SUPER or REPLICATION CLIENT privilege(s) to db user,and then restart the dble or fresh conn)."; } diff --git a/src/main/java/com/actiontech/dble/backend/delyDetection/DelayDetection.java b/src/main/java/com/actiontech/dble/backend/delyDetection/DelayDetection.java index ef96ff7bf7..42b529a313 100644 --- a/src/main/java/com/actiontech/dble/backend/delyDetection/DelayDetection.java +++ b/src/main/java/com/actiontech/dble/backend/delyDetection/DelayDetection.java @@ -229,14 +229,14 @@ public void updateLastReceivedQryTime() { } private void setTimeout() { - LOGGER.warn("delayDetection to [" + source.getConfig().getUrl() + "] setTimeout"); + LOGGER.warn("delayDetection to [" + source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl() + "] setTimeout"); delayDetectionStatus = DelayDetectionStatus.TIMEOUT; source.setDelayDetectionStatus(delayDetectionStatus); alert(AlarmCode.DB_SLAVE_INSTANCE_DELAY, errorMessage, dbGroupConfig.instanceDatabaseType().name().toLowerCase()); } private void setError() { - LOGGER.warn("delayDetection to [" + source.getConfig().getUrl() + "] setError"); + LOGGER.warn("delayDetection to [" + source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl() + "] setError"); delayDetectionStatus = DelayDetectionStatus.ERROR; source.setDelayDetectionStatus(delayDetectionStatus); if (!source.isReadInstance()) { @@ -245,7 +245,7 @@ private void setError() { } private void setOk() { - LOGGER.debug("delayDetection to [" + source.getConfig().getUrl() + "] setOK"); + LOGGER.debug("delayDetection to [" + source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl() + "] setOK"); if (errorCount.get() > 0) { errorCount.set(0); } diff --git a/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLDetector.java b/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLDetector.java index 2526145a73..9761c0a356 100644 --- a/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLDetector.java +++ b/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLDetector.java @@ -111,7 +111,7 @@ private void setStatusForNormalHeartbeat(PhysicalDbInstance source) { */ private boolean checkRecoverFail(PhysicalDbInstance source) { if (heartbeat.isStop()) { - LOGGER.warn("heartbeat[{}] had been stop", source.getConfig().getUrl()); + LOGGER.warn("heartbeat[{}] had been stop", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl()); return true; } if (heartbeat.getStatus() == MySQLHeartbeatStatus.OK) { // ok->ok diff --git a/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLHeartbeat.java b/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLHeartbeat.java index 390582a9b9..98ebeb13d5 100644 --- a/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLHeartbeat.java +++ b/src/main/java/com/actiontech/dble/backend/heartbeat/MySQLHeartbeat.java @@ -108,10 +108,10 @@ public void start(long heartbeatPeriodMillis) { public void stop(String reason) { if (isStop) { - LOGGER.warn("heartbeat[{}] had been stop", source.getConfig().getUrl()); + LOGGER.warn("heartbeat[{}] had been stop", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl()); return; } - LOGGER.info("stop heartbeat of instance[{}], due to {}", source.getConfig().getUrl(), reason); + LOGGER.info("stop heartbeat of instance[{}], due to {}", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl(), reason); isStop = true; scheduledFuture.cancel(false); initHeartbeat.set(false); @@ -164,7 +164,7 @@ boolean doHeartbeatRetry() { } void setErrorResult(String errMsg) { - LOGGER.warn("heartbeat to [" + source.getConfig().getUrl() + "] setError"); + LOGGER.warn("heartbeat to [" + source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl() + "] setError"); // should continue checking error status if (detector != null) { detector.quit(); @@ -203,7 +203,7 @@ void setResult(MySQLHeartbeatStatus result) { private void setOk() { if (LOGGER.isDebugEnabled()) { - LOGGER.debug("heartbeat to [" + source.getConfig().getUrl() + "] setOK"); + LOGGER.debug("heartbeat to [" + source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl() + "] setOK"); } MySQLHeartbeatStatus previousStatus = status; switch (status) { @@ -212,17 +212,17 @@ private void setOk() { this.errorCount.set(0); this.startErrorTime.set(-1); if (isStop) { - LOGGER.warn("heartbeat[{}] had been stop", source.getConfig().getUrl()); + LOGGER.warn("heartbeat[{}] had been stop", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl()); detector.quit(); } else { - LOGGER.info("heartbeat to [{}] setOk, previous status is timeout", source.getConfig().getUrl()); + LOGGER.info("heartbeat to [{}] setOk, previous status is timeout", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl()); heartbeat(); // timeout, heart beat again } break; case OK: break; default: - LOGGER.info("heartbeat to [{}] setOk, previous status is {}", source.getConfig().getUrl(), status); + LOGGER.info("heartbeat to [{}] setOk, previous status is {}", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl(), status); this.status = MySQLHeartbeatStatus.OK; this.errorCount.set(0); this.startErrorTime.set(-1); @@ -236,7 +236,7 @@ private void setOk() { source.updatePoolCapacity(); } if (isStop) { - LOGGER.warn("heartbeat[{}] had been stop", source.getConfig().getUrl()); + LOGGER.warn("heartbeat[{}] had been stop", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl()); detector.quit(); } } @@ -253,10 +253,10 @@ private void recordErrorCount() { private void setTimeout() { if (LOGGER.isDebugEnabled()) { - LOGGER.debug("heartbeat to [" + source.getConfig().getUrl() + "] setTimeout"); + LOGGER.debug("heartbeat to [" + source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl() + "] setTimeout"); } if (status != MySQLHeartbeatStatus.TIMEOUT) { - LOGGER.warn("heartbeat to [{}] setTimeout, previous status is {}", source.getConfig().getUrl(), status); + LOGGER.warn("heartbeat to [{}] setTimeout, previous status is {}", source.getDbGroupConfig().getName() + ":" + source.getConfig().getUrl() + ":" + source.getConfig().getUrl(), status); status = MySQLHeartbeatStatus.TIMEOUT; } }