[16.0][FIX?] preserve translate values when updating a field/model when its inherited #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inherited When inheriting from a field and changing its attributes, Odoo will override the translatable fields of ir.model and ir.model.fields, losing all of the translations. This commit preserve the old translations when the term we want to use is the same that we find in english lang
|
@sbidoul I would like to have your point of view about this one before pushing it to odoo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
When inheriting from a field and changing its attributes, Odoo will override the translatable fields of ir.model and ir.model.fields, losing all of the translations. This commit preserve the old translations when the term we want to use is the same that we find in english lang
Current behavior before PR:
Changing an attribute when inheriting a field will erase translations loaded by previous modules.
Desired behavior after PR is merged:
Loaded translations are kept if source term is the same.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr