-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Added Dockerfile for wkhtmltox v0.12.6-1 #18
[IMP] Added Dockerfile for wkhtmltox v0.12.6-1 #18
Conversation
Looks good overall, thanks! Could you
|
57d7aef
to
b2a4482
Compare
Done, I'll create the PR for the docker-compose.yml file later. I also changed the image version number in |
6b4fc1e
to
bad4b04
Compare
I know realized that I forgot to add the |
Yeah, this build and test in separate files is not optimal :/ |
bad4b04
to
3f4cad5
Compare
I kept the Focal version on a branch on our repo, we won't use it, but if someone realizes the Jammy version ends-up affecting the rendering vs Odoo.sh, it will be there: https://github.com/foodles-tech/kwkhtmltopdf/tree/agaldeano/add-0-12-6-1-wkhtmltox-dockerfile-focal |
Thanks for this contrib @alexandregaldeano |
Compared to the other Dockerfiles:
dpkg -i
+apt -f install
)I also added the compose file to go along with it.
This Dockerfile is also useable on Apple Silicon. Note that I first tried to make a Dockerfile for arm64, but the pdf rendering was very flacky.