From 87225b94fef547f00dd0bd36229bcb82e08b9781 Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Wed, 10 Apr 2024 09:06:55 -0500 Subject: [PATCH 1/4] updates for release v0.13.1 (#451) --- charts/datahub/Chart.yaml | 14 +++++++------- .../subcharts/datahub-frontend/Chart.yaml | 4 ++-- .../subcharts/datahub-frontend/values.yaml | 2 +- charts/datahub/subcharts/datahub-gms/Chart.yaml | 4 ++-- charts/datahub/subcharts/datahub-gms/values.yaml | 10 +++++++++- .../subcharts/datahub-ingestion-cron/Chart.yaml | 4 ++-- .../subcharts/datahub-ingestion-cron/values.yaml | 2 +- .../subcharts/datahub-mae-consumer/Chart.yaml | 4 ++-- .../subcharts/datahub-mae-consumer/values.yaml | 2 +- .../subcharts/datahub-mce-consumer/Chart.yaml | 4 ++-- .../subcharts/datahub-mce-consumer/values.yaml | 2 +- charts/datahub/values.yaml | 16 ++++++++-------- 12 files changed, 38 insertions(+), 30 deletions(-) diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml index 129a25b0e..5ec91eaba 100644 --- a/charts/datahub/Chart.yaml +++ b/charts/datahub/Chart.yaml @@ -4,29 +4,29 @@ description: A Helm chart for LinkedIn DataHub type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.4.4 +version: 0.4.5 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: 0.13.0 +appVersion: 0.13.1 dependencies: - name: datahub-gms - version: 0.2.164 + version: 0.2.165 repository: file://./subcharts/datahub-gms condition: datahub-gms.enabled - name: datahub-frontend - version: 0.2.156 + version: 0.2.157 repository: file://./subcharts/datahub-frontend condition: datahub-frontend.enabled - name: datahub-mae-consumer - version: 0.2.157 + version: 0.2.158 repository: file://./subcharts/datahub-mae-consumer condition: global.datahub_standalone_consumers_enabled - name: datahub-mce-consumer - version: 0.2.159 + version: 0.2.160 repository: file://./subcharts/datahub-mce-consumer condition: global.datahub_standalone_consumers_enabled - name: datahub-ingestion-cron - version: 0.2.142 + version: 0.2.143 repository: file://./subcharts/datahub-ingestion-cron condition: datahub-ingestion-cron.enabled - name: acryl-datahub-actions diff --git a/charts/datahub/subcharts/datahub-frontend/Chart.yaml b/charts/datahub/subcharts/datahub-frontend/Chart.yaml index ef7878dc4..4e1ad07c8 100644 --- a/charts/datahub/subcharts/datahub-frontend/Chart.yaml +++ b/charts/datahub/subcharts/datahub-frontend/Chart.yaml @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.156 +version: 0.2.157 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: v0.11.0 +appVersion: v0.13.1 diff --git a/charts/datahub/subcharts/datahub-frontend/values.yaml b/charts/datahub/subcharts/datahub-frontend/values.yaml index ecb1f0c3e..1730b886f 100644 --- a/charts/datahub/subcharts/datahub-frontend/values.yaml +++ b/charts/datahub/subcharts/datahub-frontend/values.yaml @@ -7,7 +7,7 @@ replicaCount: 1 revisionHistoryLimit: 10 image: - repository: linkedin/datahub-frontend-react + repository: acryldata/datahub-frontend-react tag: pullPolicy: IfNotPresent # Override the image's command & args with a new one. diff --git a/charts/datahub/subcharts/datahub-gms/Chart.yaml b/charts/datahub/subcharts/datahub-gms/Chart.yaml index fd028d9a8..2c104af55 100644 --- a/charts/datahub/subcharts/datahub-gms/Chart.yaml +++ b/charts/datahub/subcharts/datahub-gms/Chart.yaml @@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.164 +version: 0.2.165 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: v0.11.0 +appVersion: v0.13.1 diff --git a/charts/datahub/subcharts/datahub-gms/values.yaml b/charts/datahub/subcharts/datahub-gms/values.yaml index 6aed828a0..c701f1d84 100644 --- a/charts/datahub/subcharts/datahub-gms/values.yaml +++ b/charts/datahub/subcharts/datahub-gms/values.yaml @@ -7,7 +7,7 @@ replicaCount: 1 revisionHistoryLimit: 10 image: - repository: linkedin/datahub-gms + repository: acryldata/datahub-gms pullPolicy: IfNotPresent tag: # Override the image's command & args with a new one. @@ -225,6 +225,14 @@ global: # systemClientSecret: # secretRef: # secretKey: + view: + authorization: + # search/view authorization filters + enabled: true + # recommendation settings when search/view authorization is in effect + recommendations: + # whether to restrict Most Popular entities + peerGroupEnabled: true encryptionKey: secretRef: "encryption-key-secret" diff --git a/charts/datahub/subcharts/datahub-ingestion-cron/Chart.yaml b/charts/datahub/subcharts/datahub-ingestion-cron/Chart.yaml index 35a18a08d..fd6ac1d03 100644 --- a/charts/datahub/subcharts/datahub-ingestion-cron/Chart.yaml +++ b/charts/datahub/subcharts/datahub-ingestion-cron/Chart.yaml @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.142 +version: 0.2.143 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: v0.11.0 +appVersion: v0.13.1 diff --git a/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml b/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml index 2d19eb270..509ce8b24 100644 --- a/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml +++ b/charts/datahub/subcharts/datahub-ingestion-cron/values.yaml @@ -3,7 +3,7 @@ # Declare variables to be passed into your templates. image: - repository: linkedin/datahub-ingestion + repository: acryldata/datahub-ingestion tag: pullPolicy: IfNotPresent diff --git a/charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml b/charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml index 9e6652007..57f59d004 100644 --- a/charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml +++ b/charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.157 +version: 0.2.158 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: v0.11.0 +appVersion: v0.13.1 diff --git a/charts/datahub/subcharts/datahub-mae-consumer/values.yaml b/charts/datahub/subcharts/datahub-mae-consumer/values.yaml index 6adb518c6..bf8db60dd 100644 --- a/charts/datahub/subcharts/datahub-mae-consumer/values.yaml +++ b/charts/datahub/subcharts/datahub-mae-consumer/values.yaml @@ -7,7 +7,7 @@ replicaCount: 1 revisionHistoryLimit: 10 image: - repository: linkedin/datahub-mae-consumer + repository: acryldata/datahub-mae-consumer pullPolicy: IfNotPresent tag: # Override the image's command & args with a new one. diff --git a/charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml b/charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml index e967d64c6..e25ca3208 100644 --- a/charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml +++ b/charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.159 +version: 0.2.160 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: v0.11.0 +appVersion: v0.13.1 diff --git a/charts/datahub/subcharts/datahub-mce-consumer/values.yaml b/charts/datahub/subcharts/datahub-mce-consumer/values.yaml index 2f9448b95..9572f8ec3 100644 --- a/charts/datahub/subcharts/datahub-mce-consumer/values.yaml +++ b/charts/datahub/subcharts/datahub-mce-consumer/values.yaml @@ -7,7 +7,7 @@ replicaCount: 1 revisionHistoryLimit: 10 image: - repository: linkedin/datahub-mce-consumer + repository: acryldata/datahub-mce-consumer pullPolicy: IfNotPresent tag: # Override the image's command & args with a new one. diff --git a/charts/datahub/values.yaml b/charts/datahub/values.yaml index d0d31afbf..f7aca3254 100644 --- a/charts/datahub/values.yaml +++ b/charts/datahub/values.yaml @@ -3,7 +3,7 @@ datahub-gms: enabled: true image: - repository: linkedin/datahub-gms + repository: acryldata/datahub-gms # tag: "v0.11.0 # defaults to .global.datahub.version # Add custom command / arguments to this job. Useful if you need a custom startup or shutdown script # to run @@ -37,7 +37,7 @@ datahub-gms: datahub-frontend: enabled: true image: - repository: linkedin/datahub-frontend-react + repository: acryldata/datahub-frontend-react # tag: "v0.11.0" # # defaults to .global.datahub.version # Add custom command / arguments to this job. Useful if you need a custom startup or shutdown script # to run @@ -86,7 +86,7 @@ acryl-datahub-actions: datahub-mae-consumer: image: - repository: linkedin/datahub-mae-consumer + repository: acryldata/datahub-mae-consumer # tag: "v0.11.0" # defaults to .global.datahub.version # Add custom command / arguments to this job. Useful if you need a custom startup or shutdown script # to run @@ -101,7 +101,7 @@ datahub-mae-consumer: datahub-mce-consumer: image: - repository: linkedin/datahub-mce-consumer + repository: acryldata/datahub-mce-consumer # tag: "v0.11.0" # defaults to .global.datahub.version # Add custom command / arguments to this job. Useful if you need a custom startup or shutdown script # to run @@ -123,7 +123,7 @@ datahub-ingestion-cron: elasticsearchSetupJob: enabled: true image: - repository: linkedin/datahub-elasticsearch-setup + repository: acryldata/datahub-elasticsearch-setup # tag: "v0.11.0" # defaults to .global.datahub.version # Add custom command / arguments to this job. Useful if you need a custom startup or shutdown script # to run @@ -157,7 +157,7 @@ elasticsearchSetupJob: kafkaSetupJob: enabled: true image: - repository: linkedin/datahub-kafka-setup + repository: acryldata/datahub-kafka-setup # tag: "v0.11.0" # defaults to .global.datahub.version # Add custom command / arguments to this job. Useful if you need a custom startup or shutdown script # to run @@ -655,7 +655,7 @@ global: # value: password datahub: - version: v0.13.0 + version: v0.13.1 gms: protocol: "http" port: "8080" @@ -693,7 +693,7 @@ global: managed_ingestion: enabled: true - defaultCliVersion: "0.13.0.0" + defaultCliVersion: "0.13.1.2" metadata_service_authentication: enabled: true From ec89e9a9a431775348c1db52af18635aadf9eff7 Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Wed, 10 Apr 2024 16:29:52 -0500 Subject: [PATCH 2/4] disable view access perm (#452) --- charts/datahub/Chart.yaml | 4 ++-- charts/datahub/subcharts/datahub-gms/Chart.yaml | 2 +- charts/datahub/subcharts/datahub-gms/values.yaml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml index 5ec91eaba..dcd7e2d5c 100644 --- a/charts/datahub/Chart.yaml +++ b/charts/datahub/Chart.yaml @@ -4,13 +4,13 @@ description: A Helm chart for LinkedIn DataHub type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.4.5 +version: 0.4.6 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. appVersion: 0.13.1 dependencies: - name: datahub-gms - version: 0.2.165 + version: 0.2.166 repository: file://./subcharts/datahub-gms condition: datahub-gms.enabled - name: datahub-frontend diff --git a/charts/datahub/subcharts/datahub-gms/Chart.yaml b/charts/datahub/subcharts/datahub-gms/Chart.yaml index 2c104af55..be3a6f1ad 100644 --- a/charts/datahub/subcharts/datahub-gms/Chart.yaml +++ b/charts/datahub/subcharts/datahub-gms/Chart.yaml @@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.165 +version: 0.2.166 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. appVersion: v0.13.1 diff --git a/charts/datahub/subcharts/datahub-gms/values.yaml b/charts/datahub/subcharts/datahub-gms/values.yaml index c701f1d84..d4c8ec9c9 100644 --- a/charts/datahub/subcharts/datahub-gms/values.yaml +++ b/charts/datahub/subcharts/datahub-gms/values.yaml @@ -228,7 +228,7 @@ global: view: authorization: # search/view authorization filters - enabled: true + enabled: false # recommendation settings when search/view authorization is in effect recommendations: # whether to restrict Most Popular entities From cee96ec01c603d92a945e3ed3eade71c5eecb71a Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Thu, 11 Apr 2024 11:06:19 -0500 Subject: [PATCH 3/4] Add missing env var for values view access controls (#453) --- charts/datahub/Chart.yaml | 4 ++-- charts/datahub/subcharts/datahub-gms/Chart.yaml | 2 +- .../subcharts/datahub-gms/templates/deployment.yaml | 8 ++++++++ 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml index dcd7e2d5c..c5bb6da7a 100644 --- a/charts/datahub/Chart.yaml +++ b/charts/datahub/Chart.yaml @@ -4,13 +4,13 @@ description: A Helm chart for LinkedIn DataHub type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.4.6 +version: 0.4.7 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. appVersion: 0.13.1 dependencies: - name: datahub-gms - version: 0.2.166 + version: 0.2.167 repository: file://./subcharts/datahub-gms condition: datahub-gms.enabled - name: datahub-frontend diff --git a/charts/datahub/subcharts/datahub-gms/Chart.yaml b/charts/datahub/subcharts/datahub-gms/Chart.yaml index be3a6f1ad..3f36af1f2 100644 --- a/charts/datahub/subcharts/datahub-gms/Chart.yaml +++ b/charts/datahub/subcharts/datahub-gms/Chart.yaml @@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.2.166 +version: 0.2.167 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. appVersion: v0.13.1 diff --git a/charts/datahub/subcharts/datahub-gms/templates/deployment.yaml b/charts/datahub/subcharts/datahub-gms/templates/deployment.yaml index 359f6482b..cca0b2f81 100644 --- a/charts/datahub/subcharts/datahub-gms/templates/deployment.yaml +++ b/charts/datahub/subcharts/datahub-gms/templates/deployment.yaml @@ -311,6 +311,14 @@ spec: secretKeyRef: name: {{ .Values.global.datahub.metadata_service_authentication.systemClientSecret.secretRef }} key: {{ .Values.global.datahub.metadata_service_authentication.systemClientSecret.secretKey }} + {{- if .Values.global.datahub.metadata_service_authentication.view.authorization.enabled }} + - name: VIEW_AUTHORIZATION_ENABLED + value: "true" + {{- if .Values.global.datahub.metadata_service_authentication.view.authorization.recommendations.peerGroupEnabled }} + - name: VIEW_AUTHORIZATION_RECOMMENDATIONS_PEER_GROUP_ENABLED + value: "true" + {{- end }} + {{- end }} {{- end }} {{- if .Values.global.datahub.managed_ingestion.enabled }} - name: UI_INGESTION_ENABLED From 8a360a1b253fe4a47ddc627685d8916666d574af Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Thu, 11 Apr 2024 12:55:50 -0500 Subject: [PATCH 4/4] revert non-blocking update (#454) * message corruption mcl --- charts/datahub/Chart.yaml | 2 +- charts/datahub/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml index c5bb6da7a..250730f7a 100644 --- a/charts/datahub/Chart.yaml +++ b/charts/datahub/Chart.yaml @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.4.7 +version: 0.4.8 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. appVersion: 0.13.1 diff --git a/charts/datahub/values.yaml b/charts/datahub/values.yaml index f7aca3254..9bb3936bc 100644 --- a/charts/datahub/values.yaml +++ b/charts/datahub/values.yaml @@ -374,7 +374,7 @@ datahubSystemUpdate: # steps are completed, the non-blocking job runs while the rest of the # system is starting. nonblocking: - enabled: true + enabled: false # When mode = 'nonblocking' the nonblocking job should not include the above helm.sh/hook annotations annotations: # This is what defines this resource as a hook. Without this line, the