Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialisation with :cholesky sometimes fails #81

Open
nic-barbara opened this issue Jun 7, 2023 · 1 comment · May be fixed by #150
Open

Initialisation with :cholesky sometimes fails #81

nic-barbara opened this issue Jun 7, 2023 · 1 comment · May be fixed by #150
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nic-barbara
Copy link
Member

When initialising DirectRENParams with the :cholesky option, an error sometimes occurs in the construction of H. Need a better method for initialisation.
@nic-barbara nic-barbara added the bug Something isn't working label Jun 9, 2023
@nic-barbara
Copy link
Member Author

The change to the :cholesky initialisation in #103 should make this error less frequent. Still not a perfect fix, we should add some logic to check a valid H-matrix is constructed.

@nic-barbara nic-barbara added the good first issue Good for newcomers label Apr 18, 2024
@nic-barbara nic-barbara linked a pull request Oct 9, 2024 that will close this issue
Fixed cholesky init bug in a systematic way #150
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed cholesky init bug in a systematic way acfr/RobustNeuralNetworks.jl
1 participant
@nic-barbara