Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether FAF maps addresses in stack traces to correct line numbers #132

Open
mmilata opened this issue Nov 12, 2013 · 0 comments

Comments

@mmilata
Copy link
Contributor

mmilata commented Nov 12, 2013

On x86 stack, return addresses are stored on the stack that point to the next instruction (which debuginfo might translate to next line). Do we take this into account?

Example:
http://mmilata.fedorapeople.org/firehose-crash-correlation/rhytmbox/sources/e14992209f19440e0304e736d14d7e9d1c94dd67.html#file-e14992209f19440e0304e736d14d7e9d1c94dd67-line-1626
https://retrace.fedoraproject.org/faf/reports/21759/

rhythmdb_query_model_do_insert calls rhythmdb_query_model_insert_into_main_list on line 1626 but FAF says it does so on 1629 (line with next statement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants