Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code compatible with v740sp02 #87

Open
nununo opened this issue Jul 5, 2021 · 5 comments
Open

Make code compatible with v740sp02 #87

nununo opened this issue Jul 5, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@nununo
Copy link
Collaborator

nununo commented Jul 5, 2021

Consider this report: https://abaplint.app/stats/abapinho/abapTimeMachine/statement_compatibility

As suggested by Lars here: #86 (comment)

@nununo nununo mentioned this issue Jul 5, 2021
@g-back
Copy link

g-back commented Jul 6, 2021

Out of curiousity I did a local check to see what kind of statements need to be changed for 740sp02, it's mostly "quality of life" stuff:

  • inline data
  • SWITCH, FOR, VALUE, etc. statments

Could just change the readme to require 740sp08 and call it a day, up to you 😅

@nununo
Copy link
Collaborator Author

nununo commented Jul 7, 2021

Out of curiousity I did a local check to see what kind of statements need to be changed for 740sp02, it's mostly "quality of life" stuff:

How did you do it @g-back? Did you install abaplint in your fork? I tried to go to abaplint's compatibility chart for your fork but it doesn't seem to be active.

@larshp
Copy link
Contributor

larshp commented Jul 7, 2021

1: install Node on the local PC
2: do npm install @abaplint/cli -g this will install abaplint as a global executeable on the system, use the same command to update to latest
3: clone the repo to local PC
4: adjust abaplint.json
5 in the repo folder, run abaplint on command line

@g-back
Copy link

g-back commented Jul 7, 2021

Personally I used abaplint-sci client and server - but that is a bit more involved to set up than what Lars suggested.

@larshp
Copy link
Contributor

larshp commented Jul 7, 2021

heh, yea

alternatively, create a new branch, edit the abaplint.json in the branch, open a draft pull request

@nununo nununo added the enhancement New feature or request label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants