Fix QPainter issue with Qt4 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've succeeded to build pinedit with Qt4 inside Qt Creator, but the QPainter behavior has changed between Qt3 and Qt4. With Qt4 the QPainter object has to be created only during
paintEvent, as explained in Qt4 documentation.That's why most of the graphic interactions were not working, like the grid, the selection and the action previews. The fix is to add extra argument QPainter for every drawing methods that are called from the View2D::paintEvent method.
This pull request also includes few compilation warning fixes.