-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Incorrect filter method names #443
Comments
Ah good catch. We should change this and make sure the names in the Client/Node objects are also made to align with the jsonrpc names for consistency. And yes lets add these methods to the wasm binding as well. |
Raised PR #450 removing the incorrect |
Will be raising a separate PR for the Wasm bindings because that is missing for few other methods beyond these 3. Tracking in #451. |
The following 3 method names are incorrect:
As per the spec, these should be
eth_newFilter
,eth_newBlockFilter
andeth_newPendingTransactionFilter
respectively:Also, these 3 methods seem to be missing corresponding Wasm bindings. Is that intended?
The text was updated successfully, but these errors were encountered: