-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] implement notify proxy to reload browser #661
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
879f642
[feat] implement notify proxy to reload browser
jackielii 5d198f3
add proxy notify test
jackielii 1d4bf6b
add test comments
jackielii 76bf658
remove redundent contxt wrap
jackielii bd375dd
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h 39ba053
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h 32e4fb2
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h b1f3d94
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h 1c22811
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h 2f29fc2
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h def777b
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h d7e313b
Update cmd/templ/generatecmd/proxy/proxy_test.go
a-h a348f33
docs: document --notify-proxy
a-h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this is a nice addition to the templ CLI, will be using this once it's released.
Maybe even replace
--watch
?I was thinking that a change to the explanation, to make it more clear, could help this feature be more utilized when it's released.
By specifying that
--notify-proxy
takes priority over other flags, and will be exec just once, can help developers better understand the usage for this cmd.Also, the first time I read this text, it felt like I should add
--notify-proxy
as a flag to thetempl generate --watch
cmd, which would end in an unexpected outcome. (perhaps just my thinking tho :P )Could also mention that
--notify-proxy
only works if--proxy
is used. You kinda already does this and it's somewhat self explanatory, but one extra sentence could clear up any misunderstandings?PS: some of this can maybe also be applied to the
--notify-proxy
CLI help text.just some thoughts on my part.