Improve animation adjustment by look vector

[peow]

I read project readme, checked client side and server side configurations, and no such feature exists - YES

Is your feature request related to a problem? Please describe.

This mod really improves the combat significantly, and I would really like to use it, but I'm having a problem that has been bothering me a lot, which is the first-person animation
I play with a FOV higher than the standard, like many people, and when using a high FOV the animations of the arms/weapons moving are greatly affected, so that it becomes uncomfortable.

Fov.mp4

I use FOV 90, and this causes the arms to be very far from the view, causing strangeness, after all, you often see your arm floating, it would be great if there was an option where, when activated, the FOV would not cause a change in the position of the arms/weapons animation, just like what happens in Minecraft Vanilla

---

I made a comparative video showing what attacks look like using a high FOV, and how it should look in my opinion, and I also show how the animation happens when used together with the First-person Model mod, where the arms are also rendered, however the FOV doesn't affect them as much

comparative.mp4

(I just edited the video by zooming in the animation)

"If that's the problem, why not use the First-person Model instead?"

Many people would not like to use the First-person Model due to some problems it causes, such as incompatibility with items equipped in the Trinkets slots, where they end up rendering and obstructing the vision, or the fact that when looking down you has a limited view because your body takes up a large part of the screen, or when you hold an item in your hand and the item obstructs your view

Example using the crossbow:

Having this configuration where the FOV does not affect the animation in BetterCombat would be extremely useful, where you could benefit from first-person animations, even playing with a high FOV

---

• Another thing I would like to highlight is the first-person animation when you move the camera up or down, the animation of the arms and weapons are not fixed in the player's view, as happens in Minecraft Vanilla, but rather try to follow the third person animation, but as I show in the video this shouldn't be like this since the hitbox follows the player's vision, making the animation out of place

Animation.Locked.2.mp4

What I ask for is a configuration in which the animation is fixed in the player's view, this would make it more comfortable to see, it's strange to have your arms floating away and not following your crosshair

I believe that these two changes should be the default, but if you disagree, that's okay, at least having a way to activate these functions would be great; If this is possible, I would ask for an update to Fabric 1.20.1 with the new functions

Thank you for reading and congratulations on the mod

[ZsoltMolnarrr]

I think I understand your issue, however, I don't think there is any kind of solution that doesn't require rewriting the first person render stack.

[peow]

I see
It would be interesting to know what other users think about this, but it's unlikely that many people will see this issue on Github
what do you think about creating a poll on your Discord server, saying something like this:

---

Currently BetterCombat's first-person animation replicates the third-person animation, a suggestion came from a user that the first-person animation should be similar to Minecraft Vanilla, with the player's arms fixed on the screen, but putting this into the mod would take a lot of time, if BetterCombat's current animation doesn't bother you vote for the first option, if you believe that the proposed change would be better, vote for the second option

Video comparative:

Comparative.mp4

1️⃣ I like the current first-person animation (Default Behaviour)
2️⃣ I prefer the proposed new animation (Modified Version)

1️⃣ 2️⃣

---

Video download link to use on Discord - https://drive.google.com/file/d/1hoepilDwXVJQny9onCZHFG6ETs9aVFK3/view

screenshot of how it would look:

so if a lot of people prefer the new animation it would be worth the effort to implement it in the mod

[mattmoparkour]

This isn't just high fov, the fpv for this mod just looks quite bad imo

[peow]

I see It would be interesting to know what other users think about this, but it's unlikely that many people will see this issue on Github what do you think about creating a poll on your Discord server, saying something like this:

what do u think?

[ZsoltMolnarrr]

I see It would be interesting to know what other users think about this, but it's unlikely that many people will see this issue on Github what do you think about creating a poll on your Discord server, saying something like this:

Currently BetterCombat's first-person animation replicates the third-person animation, a suggestion came from a user that the first-person animation should be similar to Minecraft Vanilla, with the player's arms fixed on the screen, but putting this into the mod would take a lot of time, if BetterCombat's current animation doesn't bother you vote for the first option, if you believe that the proposed change would be better, vote for the second option

Video comparative:

Comparative.mp4

1️⃣ I like the current first-person animation (Default Behaviour) 2️⃣ I prefer the proposed new animation (Modified Version)

1️⃣ 2️⃣

Video download link to use on Discord - https://drive.google.com/file/d/1hoepilDwXVJQny9onCZHFG6ETs9aVFK3/view

screenshot of how it would look:

so if a lot of people prefer the new animation it would be worth the effort to implement it in the mod

Hi!
The proposed "new animation (Modified Version)" was my original goal to implement.
Unfortunately I don't think it is possible, tried it many times, but dynamically rotating ongoing animations is extremely tricky.

Feel free to send the implementation of second version as a pull request, I would be eager to review and merge it.
Until then, this issue is non-actionable for me. (Meaning I am unable to improve it).

[peow]

it would be interesting if you created a label called “Help Wanted” and added this Issue to it, and also pinned it to the Issues homepage so that someone who knows how to fix it would know that you need help