Get rid of compiler warnings

Zilliqa · Dec 18, 2024 · 0f49ee7 · 0f49ee7
1 parent a1db3ed
commit 0f49ee7
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 36 deletions.
diff --git a/script/CheckVariant.s.sol b/script/CheckVariant.s.sol
@@ -11,7 +11,7 @@ import {console} from "forge-std/console.sol";
 contract CheckVariant is Script {
     using ERC165Checker for address;
 
-    function run(address proxy) external {
+    function run(address proxy) external view {
 
         if (proxy.supportsInterface(type(ILiquidDelegation).interfaceId))
             console.log("ILiquidDelegation");

diff --git a/src/LiquidDelegation.sol b/src/LiquidDelegation.sol
@@ -57,40 +57,40 @@ contract LiquidDelegation is BaseDelegation, ILiquidDelegation {
         bytes calldata,
         bytes calldata,
         bytes calldata
-    ) public override {
+    ) public pure override {
         revert("not implemented");
     }
 
-    function migrate(bytes calldata) public override {
+    function migrate(bytes calldata) public pure override {
         revert("not implemented");
     }
 
     function stake() external override payable {
         revert("not implemented");
     }
 
-    function unstake(uint256) external override returns(uint256) {
+    function unstake(uint256) external pure override returns(uint256) {
         revert("not implemented");
     }
 
-    function claim() external override {
+    function claim() external pure override {
         revert("not implemented");
     }
 
-    function collectCommission() public override {
+    function collectCommission() public pure override {
         revert("not implemented");
     }
 
-    function stakeRewards() public override {
+    function stakeRewards() public pure override {
         revert("not implemented");
     }
 
-    function getPrice() public view returns(uint256) {
+    function getPrice() public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function supportsInterface(bytes4 interfaceId) public view override returns (bool) {
-       return interfaceId == type(ILiquidDelegation).interfaceId || super.supportsInterface(interfaceId);
+    function supportsInterface(bytes4 _interfaceId) public view override returns (bool) {
+       return _interfaceId == type(ILiquidDelegation).interfaceId || super.supportsInterface(_interfaceId);
     }
 
     function interfaceId() public pure returns (bytes4) {

diff --git a/src/LiquidDelegationV2.sol b/src/LiquidDelegationV2.sol
@@ -210,8 +210,8 @@ contract LiquidDelegationV2 is BaseDelegation, ILiquidDelegation {
         return $.lst;
     }
 
-    function supportsInterface(bytes4 interfaceId) public view override returns (bool) {
-       return interfaceId == type(ILiquidDelegation).interfaceId || super.supportsInterface(interfaceId);
+    function supportsInterface(bytes4 _interfaceId) public view override returns (bool) {
+       return _interfaceId == type(ILiquidDelegation).interfaceId || super.supportsInterface(_interfaceId);
     }
 
     function interfaceId() public pure returns (bytes4) {

diff --git a/src/NonLiquidDelegation.sol b/src/NonLiquidDelegation.sol
@@ -52,64 +52,64 @@ contract NonLiquidDelegation is BaseDelegation, INonLiquidDelegation {
         bytes calldata,
         bytes calldata,
         bytes calldata
-    ) public override {
+    ) public pure override {
         revert("not implemented");
     }
 
-    function migrate(bytes calldata) public override {
+    function migrate(bytes calldata) public pure override {
         revert("not implemented");
     }
 
     function stake() external payable override {
         revert("not implemented");
     }
 
-    function unstake(uint256) external override returns(uint256) {
+    function unstake(uint256) external pure override returns(uint256) {
         revert("not implemented");
     }
 
-    function claim() external override {
+    function claim() external pure override {
         revert("not implemented");
     }
 
-    function collectCommission() public override {
+    function collectCommission() public pure override {
         revert("not implemented");
     }
 
-    function stakeRewards() public override {
+    function stakeRewards() public pure override {
         revert("not implemented");
     }
 
-    function rewards() public view returns(uint256) {
+    function rewards() public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function rewards(uint64) public view returns(uint256) {
+    function rewards(uint64) public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function getDelegatedStake() public view returns(uint256) {
+    function getDelegatedStake() public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function withdrawRewards(uint256, uint64) public returns(uint256) {
+    function withdrawRewards(uint256, uint64) public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function withdrawRewards(uint256) public returns(uint256) {
+    function withdrawRewards(uint256) public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function withdrawAllRewards(uint64) public returns(uint256) {
+    function withdrawAllRewards(uint64) public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function withdrawAllRewards() public returns(uint256) {
+    function withdrawAllRewards() public pure returns(uint256) {
         revert("not implemented");
     }
 
-    function supportsInterface(bytes4 interfaceId) public view override returns (bool) {
-       return interfaceId == type(INonLiquidDelegation).interfaceId || super.supportsInterface(interfaceId);
+    function supportsInterface(bytes4 _interfaceId) public view override returns (bool) {
+       return _interfaceId == type(INonLiquidDelegation).interfaceId || super.supportsInterface(_interfaceId);
     }
 
     function interfaceId() public pure returns (bytes4) {

diff --git a/src/NonLiquidDelegationV2.sol b/src/NonLiquidDelegationV2.sol
@@ -367,8 +367,8 @@ contract NonLiquidDelegationV2 is BaseDelegation, INonLiquidDelegation {
 
     function collectCommission() public override {}
 
-    function supportsInterface(bytes4 interfaceId) public view override returns (bool) {
-       return interfaceId == type(INonLiquidDelegation).interfaceId || super.supportsInterface(interfaceId);
+    function supportsInterface(bytes4 _interfaceId) public view override returns (bool) {
+       return _interfaceId == type(INonLiquidDelegation).interfaceId || super.supportsInterface(_interfaceId);
     }
 
     function interfaceId() public pure returns (bytes4) {

diff --git a/test/BaseDelegation.t.sol b/test/BaseDelegation.t.sol
@@ -241,6 +241,9 @@ abstract contract BaseDelegationTest is Test {
         vm.deal(address(delegation), address(delegation).balance + 10_000 ether);
 
         uint256 totalUnstaked;
+        uint256 totalPending;
+        uint256[2][] memory claims;
+
         for (uint256 j = 0; j < steps; j++) {
             console.log("--------------------------------------------------------------------");
             vm.startPrank(stakers[i-1]);
@@ -251,12 +254,12 @@ abstract contract BaseDelegationTest is Test {
 
             //console.log("block number: %s", block.number);
             console.log("claimable: %s", delegation.getClaimable());
-            uint256[2][] memory claims = delegation.getPendingClaims();
+            claims = delegation.getPendingClaims();
             console.log("%s pending claims:", claims.length);
-            uint256 totalPending;
-            for (uint256 j = 0; j < claims.length; j++) {
-                console.log("%s can claim %s in block %s", stakers[i-1], claims[j][1], claims[j][0]);
-                totalPending += claims[j][1];
+            totalPending = 0;
+            for (uint256 k = 0; k < claims.length; k++) {
+                console.log("%s can claim %s in block %s", stakers[i-1], claims[k][1], claims[k][0]);
+                totalPending += claims[k][1];
             }
             assertEq(delegation.getClaimable() + totalPending, totalUnstaked, "claims must match unstaked amount");
 
@@ -271,9 +274,9 @@ abstract contract BaseDelegationTest is Test {
         console.log("--------------------------------------------------------------------");
         console.log("block number: %s", block.number);
         console.log("claimable: %s", delegation.getClaimable());
-        uint256[2][] memory claims = delegation.getPendingClaims();
+        claims = delegation.getPendingClaims();
         console.log("%s pending claims:", claims.length);
-        uint256 totalPending;
+        totalPending = 0;
         for (uint256 j = 0; j < claims.length; j++) {
             console.log("%s can claim %s in block %s", stakers[i-1], claims[j][1], claims[j][0]);
             totalPending += claims[j][1];