Added autocomplete="off" to some password fields #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redfast00
approved these changes
May 23, 2024
chvp
reviewed
May 24, 2024
| @@ -34,7 +34,7 @@ | |||
|
|
|||
| <div class="field"> | |||
| <label class="label">Password</label> | |||
| <input class="input is-medium" name="password" type="password" placeholder="Password" required /> | |||
| <input class="input is-medium" name="password" type="password" placeholder="Password" required autocomplete="off" /> | |||
There was a problem hiding this comment.
Why would we not want autocomplete when signing in? I think we want to allow people to use password managers?
There was a problem hiding this comment.
We got an email from UGent's automated vuln scanner
There was a problem hiding this comment.
After looking at this a bit better; I don't really agree with the vuln scanner, and think the best course of action is emailing DICT to disable those plugins. Another garbage detection as an example:
redfast00
requested changes
May 24, 2024
|
I am also against this, as this creates a less secure situation in my option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.