Fix wrong can message length

[joaoantoniocardoso]

All defined topics has its own length defined on can_ids.h.

See lines below:
https://github.com/ZeniteSolar/MAB20/blob/master/firmware/src/can_app.c#L57
https://github.com/ZeniteSolar/MAB20/blob/master/firmware/src/can_app.c#L77

Instead of CAN_MSG_GENERIC_STATE_LENGTH, it should be using CAN_MSG_MAB19_STATE_LENGTH and CAN_MSG_MAB19_PUMPS_LENGTH.

[s0sharma]

Hi, I would like to work on this.

[joaoantoniocardoso]

Hi @s0sharma, nice! We'll appreciate your contribution! To do so, you can follow the standard open source community workflow:

• create a fork,
• modify,
• open a PR,

Please feel free to ask any question, thanks!

[joaoantoniocardoso]

Yeah, exactly, as simple as it sounds. Actually the same problem exists in other modules too, but luckily it happens that the length for the generic state message and the state message for all modules are the same, so, nothing critical, it keeps working correctly even when the wrong macro was used for state messages. No pressure here, but I would be very happy if you fix all these: https://github.com/search?q=org%3AZeniteSolar+CAN_MSG_GENERIC_STATE_LENGTH&type=code Thanks again!

…

On Thu, Aug 12, 2021 at 7:25 AM s0sharma ***@***.***> wrote: I have to change only can_app.c <https://github.com/ZeniteSolar/MAB20/blob/master/firmware/src/can_app.c> File ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNFMHW24RJSZ5L5TGIE2L3T4OOQ7ANCNFSM5B75WUTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .