New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passing things by value and then not changing it #23

Open

ReiquelApplegate opened this issue Apr 14, 2024 · 2 comments

Contributor

ReiquelApplegate commented Apr 14, 2024

render_text_lines for example takes a vector by value and then does not change it. It then iterates over them by value.

Contributor

Gleeok commented Apr 14, 2024

Unacceptable!

Contributor Author

ReiquelApplegate commented Apr 16, 2024

zmap::CapCommandHistory() iterates over the undo_stack commands by value like this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment