New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superfluous variables #16

Open

ReiquelApplegate opened this issue Mar 30, 2024 · 3 comments

Contributor

ReiquelApplegate commented Mar 30, 2024

In count_item_drop_sets() in zquest.cpp, we could probably easily remove the bool found.

Contributor Author

ReiquelApplegate commented Mar 30, 2024

File->Save As runs this function

Contributor Author

ReiquelApplegate commented Mar 30, 2024

the int32_t count declaration uselessly initializes it to zero since the for loop reinitializes it to 255

Contributor Author

ReiquelApplegate commented Mar 30, 2024

this function also assumes that the questmaker is using a contiguous sequence of item drop slots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment