Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport project to support java 8 #17

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Kaydax
Copy link

@Kaydax Kaydax commented Jan 26, 2024

This not only fixes #11 but also allows MultiYggdrasil to support versions older than Minecraft 1.17.

This also adds shadowjar remapping of asm and gson, allowing it to work with forge and older versions without overlapping libraries. (Which normal authlib-injector does for asm)

Everything works the same as It currently does, but it just replaces code that uses the newer java versions with code that works with java 8

I also added in portable gradle for people who don't have a system install of it

I've tested this on:
Vanilla 1.20.4
Vanilla 1.12.2
Vanilla 1.8.9
Forge 1.12.2

I feel like thats a good amount of testing to make sure it works with both new and old versions

@YuxuanZuo
Copy link
Owner

YuxuanZuo commented Jan 26, 2024

Thank for your contribution! But unfortunately there may be a duplicate username problem on lower versions of Minecraft. I will merge this pr after completing the backward compatibility of the username distinction function

@Shanwer
Copy link

Shanwer commented Jul 4, 2024

This works on my 1.12.2 server, however 1.21 players via authlib are unable to talk as #20 points out.

@Kaydax
Copy link
Author

Kaydax commented Jul 4, 2024

This works on my 1.12.2 server, however 1.21 players via authlib are unable to talk as #20 points out.

I'll test this in a bit and see what I can do

@Shanwer
Copy link

Shanwer commented Jul 4, 2024

This works on my 1.12.2 server, however 1.21 players via authlib are unable to talk as #20 points out.

I'll test this in a bit and see what I can do

Sorry, it was caused by my chat plugin with enforce-secure-profile = false and client mod "noChatReports", your fork still works perfertly:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

不支持Java17以下的版本启动
3 participants