Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get('orders') accepts parameter "customer" instead of "customer_id" #40

Open
dmoebius opened this issue Sep 7, 2023 · 1 comment
Open
Assignees

Comments

@dmoebius
Copy link

dmoebius commented Sep 7, 2023

The GET orders endpoint accepts a "customer" parameter instead of "customer_id". The typescript definitions need to reflect this.

I think this can most easily achieved by changing:

export type OrdersParams = Partial<Orders>;

to

export type OrdersParams = Partial<Omit<Orders, 'customer_id'> & {'customer': number}>;
@Yuri-Lima
Copy link
Owner

Hi, @dmoebius, i have assigned you to this issue, if you have a chance to create a PR, would be very helpfull. Thank in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants