Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin settings do not save correctly #172

Open
azbulutlu opened this issue Apr 13, 2022 · 6 comments
Open

Admin settings do not save correctly #172

azbulutlu opened this issue Apr 13, 2022 · 6 comments

Comments

@azbulutlu
Copy link

azbulutlu commented Apr 13, 2022

Describe the bug

Some of the admin settings do not work correctly on a fresh install.

Context

  • Hardware: VPS bought online
  • YunoHost version: 4.3.6.3
  • I have access to my server: Through SSH
  • Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no
  • Using, or trying to install package version/branch: 11.2

Steps to reproduce

  • Fresh install of pixelfed.
  • enabled admin interface as directed.

Expected behavior

Some settings can be changed, but others do not. (e.g. Branding instance title, long and short descriptions, about page headline, custom CSS)

The settings seems to be save, but when admin panel is refreshed it is clear changes were not reflected.

notes:

this is also referenced in the following issue upstream but putting it here as well as many of the cases mentioned seems to be yunohost related.

Some users can get partial fixes by chmoding some folders but not sure if this is the correct workaround.

@lapineige
Copy link
Member

lapineige commented Apr 17, 2022

Thank you for raising this issue.

Some users can get partial fixes by chmoding some folders but not sure if this is the correct workaround.

This, and the fact that you are listing issues with variables defined in the .env config file, such as the instance title.

Right now the permissions seems to be read-only and the file owned by pixelfed user (group www-data). So indeed Pixelfed can't change it.
sudo chmod 600 /var/www/pixelfed/.env should fix it. Can you confirm it does for you ?

@azbulutlu
Copy link
Author

azbulutlu commented Apr 17, 2022

I am running into a bit of an issue testing this as now, when I chmod the views folder back to 770 (which it was at) it still works.

chmodding the .env file didn't do anything, I think this might be because the config cache overrides the .env file? (I remember reading that somewhere in the pixelfed github - which I think makes sense as I don't see the instance title long description and the short description at the .env file yet they are reflected on the live instance)

About and custom CSS still doesn't work (I can enable custom css but the content of the box resets).

sorry to be the bearer of bad news and thank you for looking into this. :)

@lapineige
Copy link
Member

lapineige commented Apr 17, 2022

Then as I don't understand how this works I'm out of clue 😅

@azbulutlu
Copy link
Author

well both of us in this case. I am guessing the config cache is what gets updated when one does that artisan clear config cache line after each change. but where it is stored, I have no idea.

@retiolus
Copy link

Any news on this issue?

@lapineige
Copy link
Member

Not from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants