find_additional_public_hostnames() enhancement for virtual hosts?

[lsl-at]

Hi!

I've just migrated my Zimbra host and stumbled upon certbot_zimbra.sh.

While looking through the code I see that find_additional_public_hostnames() queries the property zimbraPublicServiceHostname, as in:

[zimbra@HOST ~]$ zmprov -l gd DOMAIN.COM zimbraPublicServiceHostname
# name domain.com
zimbraPublicServiceHostname: webmail.domain.com

But it should rather be querying the property zimbraVirtualHostname, as in:

[zimbra@HOST ~]$ zmprov -l gd DOMAIN.COM zimbraVirtualHostname 
# name domain.com
zimbraVirtualHostname: webmail.domain.com
zimbraVirtualHostname: mail.domain.com
zimbraVirtualHostname: smtp.domain.com

I would like to patch this function. What do you think about that, or should it be added as another feature?

Regards
Friedl

[maxxer]

They're probably both valid. Maybe we can extend find_additional_public_hostnames function to look for zimbraVirtualHostname as well and add them to the array.

I don't know if it's worth separating them into another function, as the purpose is the same...

[lsl-at]

At least on my setup the output of zimbraPublicServiceHostname is contained in zimbraVirtualHostname.

But I'm not sure if everybody sets zimbraVirtualHostname to contain zimbraPublicServiceHostname.

[maxxer]

I checked one of my multi domain installations and zimbraVirtualHostname is empty

[lsl-at]

If you don't add at least one hostname to zimbraVirtualHostname, then your users always have to use the full email address when logging in. If their account is not in the same domain as the Zimbra host.

I usually let the DNS entry of "webmail.DOMAIN.com" point to the Zimbra host. Then it set zimbraPublicServiceHostname to "webmail.DOMAIN.com" and add the same value to zimbraVirtualHostname. The URL http://webmail.DOMAIN.com/, is the one I then communicate to users of "DOMAIN.com".

Because of how K9-Mail on Android does automatic setup, I add "imap.DOMAIN.com" and "smtp.DOMAIN.com" as DNS entries and to zimbraPublicServiceHostname as well.

[lsl-at]

How about as shown in the following commit lsl-at@731b524?

[maxxer]

It looks fine to me, please issue a PR so we can review it before merging.

Please include relevant documentation in README and in help, adding where domains are detected. Also, add entry to an unreleased version in changelog. Thank you!!

[lsl-at]

I'll try. It'll be the first git PR of my life :-)

[lsl-at]

PR submitted as #162 😄.