Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why not use AppCompat's setApplicationLocales and getApplicationLocales? #55

Open
itsramiel opened this issue May 30, 2024 · 0 comments

Comments

@itsramiel
Copy link

Hello,

Thank you for the library and the blog post. It has been very useful to me.
This is more of a question more suitable in a discussion tab but I couldnt find a discussion tab so adding it here.

I have a question that I am curious about.
While checking android docs about handling in app language changes, they mentioned using androidx AppCompat's setApplicationLocales and getApplicationLocales which seems to have a consistent api accross different api levels, and also auto persists language changes using the autoStoreLocales.

I am wondering why the library does not utilize that and instead handle different api levels differently and manages its own storage.

Are there downsides to the appcompat approach and you think the manual way offers something better or do you think the appcompat's way is actually better but did not update the code cause why fix what is already working or you don't have the time for it.

Thank you very much and if anything I said doesnt seem right, please bear in mind I am a beginner android dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant