-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easiest way to identify plugins that use plugin-updater-checker #581
Comments
I don't think there's a reliable way to do that. Looking for a specific string like the For plugins that use Composer, you could look for a For active plugins, you could look at callbacks attached to the |
Thanks for your quick response @YahnisElsts It sounds like maybe this would be unreliable and/or require scanning the entire plugin tree, which would probably cause performance issues based on my previous tests doing that. In the future if you end up having a narrower way to check the plugin main files, I'd love to know. Thanks! |
@jessuppi If your goal is to exclude any plugins that aren't from wordpress.org, then see this fragment: #578 (comment) . (The code there isn't restricted to use of any particular updates-checking class). |
Thanks @DavidAnderson684 What if someone installs a third party WordPress plugin that has the same namespace as a plugin from WP.org would it potentially get skipped using your filter? Wouldn't the calls to |
@jessuppi Plugins in the wordpress.org plugin directory are forbidden by the directory to include an "UpdateURI" header pointing elsewhere. |
@DavidAnderson684 But couldn't your entire code be reduced to simply checking for an |
It is true that the code won't detect any plugin that neglects to use that standard header. The best way to fix that is to inform any plugin authors to add it. And, of course, you can edit the code snippet to also include any plugins that include the Github header, if that's relevant. |
Good idea @DavidAnderson684 ... this is now added to RepoMan 1.8.0:
https://github.com/littlebizzy/repoman Progress at least! A bit off-topic, sorry @YahnisElsts but hopefully it proves useful as a public note for now... |
Hello, thanks for this awesome project.
I'm currently working on RepoMan which is an MU plugin that extends the native WP plugin search to include plugins from GitHub that can be installed... it also prevents WordPress.org from sending "update" notices on any plugins that RepoMan detects already support the Git Updater software by looking for string
GitHub Plugin URI
in the main file:https://github.com/littlebizzy/repoman
One of your users asked if we could support your software also.
Do you have a recommendation on the easiest way for RepoMan to scan installed plugins in WordPress and identify which plugins support
plugin-update-checker
that is hopefully lightweight and scalable?For example, looking for string
PluginUpdateChecker
in the main file should that be enough? Cheers!The text was updated successfully, but these errors were encountered: