Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITransitionFactory in CloneableVertexGraphExplorerAlgorithm and TransitionFactoryImplicitGraph #199

Open
simon-flanagan opened this issue Dec 19, 2019 · 1 comment

Comments

@simon-flanagan
Copy link

This may be me misunderstanding something....however....

There doesn't seem to be a way to set TransitionFactories in either of the classes that use them (CloneableVertexGraphExplorerAlgorithm and TransitionFactoryImplicitGraph). The constructors don't accept these and the property is get only.

Again, it may be that my understanding of the expected functionality is flawed, but I don't see how either of these implementation classes can do anything really useful without being able to set a transition factory.

I can fix a copy for what I need - if you would like me to contribute any changes then let me know.

@KeRNeLith
Copy link

Hello,
I forked this QuickGraph repository (here) and updated these implementations, in my opinion, in a clearer way (see here).
From what I understood, you should add classes implementing the ITransitionFactory to either the graph or the algorithm. And then they will be browsed on demand.

I also made a lot of unit tests in this fork I advise you to have a look at them to have an idea (here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants