Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_iter #40

Closed
jayvdb opened this issue Jun 7, 2024 · 4 comments · Fixed by #42
Closed

from_iter #40

jayvdb opened this issue Jun 7, 2024 · 4 comments · Fixed by #42

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Jun 7, 2024 •
edited
Loading

The tests use https://crates.io/crates/temp-env , which is nice, but I would prefer to be using something like envy.from_iter https://github.com/softprops/envy/blob/e22035c3b91f999c325a44c0c77f0e6e05750da3/src/lib.rs#L330

For context, I am interested in a from_iter for my tests in a crate which uses serde-env
@Xuanwo
Copy link
Owner

Xuanwo commented Jun 7, 2024

Are you talking about adding an API called serde_env::from_iter?

@jayvdb
Copy link
Contributor Author

jayvdb commented Jun 7, 2024

Yes. Is that ok?

It would make serde-env a drop-in replacement for envy. c.f. softprops/envy#76 (comment)

@Xuanwo
Copy link
Owner

Xuanwo commented Jun 7, 2024

Yes. Is that ok?

Yep, it looks good to me! Would you like to impelment it?

@jayvdb
Copy link
Contributor Author

jayvdb commented Jun 7, 2024

ya, will do tmr

@jayvdb jayvdb mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add from_iter and from_iter_with_prefix jayvdb/serde-env
2 participants
@jayvdb @Xuanwo