Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform File #32

Open
vroland opened this issue Mar 24, 2021 · 13 comments
Open

Waveform File #32

vroland opened this issue Mar 24, 2021 · 13 comments
Labels

Comments

@vroland
Copy link

vroland commented Mar 24, 2021

Hi,
Recently, I added support for vendor wavforms to epdiy. These are special files that describe how the display must be driven for accurate grayscale.
This allows to make arbitrary grayscale-to-grayscale transitions, which is not possible with the version of epdiy this library is based on at the moment. There are some other improments as well, especially to the user-facing API. So incorporating them or finding a way to keep this fork more up to date should be discussed in a separate issue.
You have sent me the fitting waveform file via e-Mail already, but it would be nice to have it publicly available for anyone who needs it. That would allow me to add the appropriate header to epdiy directly, which would make it way easier for people to get use out of this file.
So: Could you add the V220_C244_BA5701_ED047TC2U1_TC.wbf waveform file to the repository?

Regards,
Valentin

@markbirss
Copy link

Please upload the V220_C244_BA5701_ED047TC2U1_TC.wbf waveform file for all of us

@LilyGO
Copy link
Contributor

LilyGO commented May 6, 2021

@vroland Ok.
Sorry, I haven’t logged into GitHub recently
Thank you for your efforts, I should reply to you as soon as possible

@LilyGO
Copy link
Contributor

LilyGO commented May 6, 2021

@vroland Have you submitted your pull request? So that I can approve your merge request.
Contributors will also show your name

@vroland
Copy link
Author

vroland commented May 6, 2021

Making a pull request for the waveform implementation only is unfortunately not trivial, because a lot of refactoring happened in epdiy since then. Maybe we should discuss this in #33 instead?
Also, publishing the waveform file would be a prerequisite for generating a suitable waveform header.

@hacksics
Copy link

I've started using epdiy instead of this fork and it makes sense to use the base repository as it has lot of new features and updated frequently.

But what I have noticed was the image colors are not accurate as EPD47 when using native epdiy. Is this due to using the EPD_BUILTIN_WAVEFORM file instead of vendor waveform?

@vroland as suggested by @LilyGO can you create a pull request by just adding the raw waveform file so we can use it to generate header file using waveform_hdrgen.py ?

@vroland
Copy link
Author

vroland commented May 31, 2021

@hacksics Because I'm unsure of the copyright situation, I would prefer that @LilyGO publish the file, since I got it from them.

@hacksics
Copy link

hacksics commented Jun 1, 2021

Ok makes sense. @LilyGO @lewisxhe can you please chime in..

@Jason2866
Copy link

+1 @LilyGO for uploading V220_C244_BA5701_ED047TC2U1_TC.wbf

@LilyGO
Copy link
Contributor

LilyGO commented Oct 21, 2021

https://github.com/Xinyuan-LilyGO/LilyGo-EPD47/tree/master/Waveform_header

@Jason2866
Copy link

Thx!

@hacksics
Copy link

@vroland can you please integrate this in to epdiy repo ?

@entozoon
Copy link

@hacksics PR created

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants