Phoenix v2024.1 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the projects creates .o files, .so files and copies some headers. None of these artifacts are tracked under source control so we don't need to see them. * [amdair] xaie: Enable backend selection at init time All IO backends are compiled no matter the configuration. The only thing that changes is the XAIE_DEFAULT_BACKEND macro that points to the correct backend as specified by a compile-time flag. There is no reason why the backend selection cannot be made at runtime, giving more control to the application as to how it wants to use the library. Add a configuration item specifying the backend. When the library is initialized, the backend will be chosen based on this parameter. If the user-selected backend index is out of range, the library will fall back to the existing default backend logic. * [amdair] driver: add amdair backend The I/O commands are sent to the device using the amdair driver's sysfs interface. This requires the amdair driver to be loaded before sending any commands. --------- Signed-off-by: Joel Nider <[email protected]> Co-authored-by: Joel Nider <[email protected]>
The XAie_InstDeclare define declares a structure, but didn't completely initialize it. This patch initializes the structure to a default value.
There are several trivial warnings that appear when building. Address them as necessary by fixing the problems. In general, unused parameters to functions that are part of an interface cannot be removed so they are marked with the UNUSED macro. Signed comparisons can never be negative and uints can never be larger than UINT_MAX. XAIE columns are generally a u8 type (limited to 256 columns) although stored in a u32 in places. If we ever need to support more than 256 columns this needs to change across the board. Signed-off-by: Joel Nider <[email protected]>
…ry will have an undefined symbol and the mlir-air tests will fail to compile (#8)
* Removed illegal cast to struct type * Replaced variable length array with malloc * Added required `=` to array initialization with designator * Removed use of unistd.h * Replaced usage of pthread.h * Moved the alignment macro to avoid a circular dependency * Disabled use of gcc-style attribute * Replaced illegal arithmetic on void pointer
makslevental
force-pushed
the
phoenix_v2024.1
branch
from
2b1feff
to
8a43823
Compare
The new code moves several hooks from driver to fal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #2 to xlnx_rel_v2024.1