CR-1217846: In trace and profiling provide a better name than "Edge" on edge platforms #8617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clear name Signed-off-by: Jason Villarreal <[email protected]>
hackwa
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Profiling was incorrectly ignoring metadata regarding each platform's name and using the nondescriptive term "edge" for all boards PL sections. The name of the platform was successfully read from the metadata from the profiling library, but then it was overwritten with the generic term "edge."
How problem was solved, alternative solutions (if any) and why they were rejected
This pull request removes the extraneous setting of the platform name in the plugin objects and leaves the correct name as determined by the centralized database which parses the metadata.
Risks (if any) associated the changes in the commit
Automated scripts that look for the generic name "edge" will now find a different name for the PL portion of trace.
What has been tested and how, request additional testing if necessary
A hardware and hardware emulation design that generates PL trace.
Documentation impact (if any)
Any Vitis documentation that references the trace PL section as "edge."