Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json option for advance reports #8558

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Add json option for advance reports #8558

merged 5 commits into from
Oct 23, 2024

Conversation

AShivangi
Copy link
Collaborator

@AShivangi AShivangi commented Oct 22, 2024

Problem solved by the commit

  • CR-1217445 [xrt-smi] verbosity enabled when a single test is run
  • CR-1217447 [xrt-smi] remove xclbin path/dpu seq path from validate verbose
  • add --json option to advanced reports

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

How problem was solved, alternative solutions (if any) and why they were rejected

  • removed the if statement which checks if a single test is run
  • remove xclbin path/dpu seq and kernel name from validate
  • add a json option

Risks (if any) associated the changes in the commit

Low

What has been tested and how, request additional testing if necessary

Tested on stx/mcdm:

>xrt-smi advanced --report clocks --json
{
    "clocks": [
        {
            "id": "H Clock",
            "description": "System",
            "freq_mhz": "800"
        },
        {
            "id": "MP-NPU Clock",
            "description": "System",
            "freq_mhz": "400"
        }
    ]
}
>xrt-smi advanced --report clocks
Clocks
  H Clock                : 800 MHz
  MP-NPU Clock           : 400 MHz
>xrt-smi advanced --report preemption
Premption Telemetry Data
 No hardware contexts running on device
>xrt-smi advanced --report preemption --json
Premption Telemetry Data
 No hardware contexts running on device
>xrt-smi advanced --report preemption
Premption Telemetry Data
  |User Task  ||Ctx ID  ||Set Hints  ||Unset Hints  ||Checkpoint Events  ||Frame Boundary Events  |
  |-----------||--------||-----------||-------------||-------------------||-----------------------|
  |0          ||1       ||N/A        ||N/A          ||N/A                ||N/A                    |
>xrt-smi advanced --report preemption --json
{
    "telemetry": [
        {
            "user_task": "0",
            "slot_index": "1",
            "preemption_flag_set": "N\/A",
            "preemption_flag_unset": "N\/A",
            "preemption_checkpoint_event": "N\/A",
            "preemption_frame_boundary_events": "N\/A"
        }
    ]
}

Documentation impact (if any)

N/A

Signed-off-by: AShivangi <[email protected]>
@AShivangi AShivangi requested a review from rchane October 23, 2024 15:55
Signed-off-by: AShivangi <[email protected]>
@stsoe stsoe merged commit 1291c59 into Xilinx:master Oct 23, 2024
18 checks passed
@AShivangi AShivangi deleted the adv-json branch October 24, 2024 17:53
parthash0804 pushed a commit to parthash0804/XRT that referenced this pull request Oct 29, 2024
* add json opt, remove some validate verbose logging

Signed-off-by: AShivangi <[email protected]>

* submodule change

Signed-off-by: AShivangi <[email protected]>

* remove patch file

Signed-off-by: AShivangi <[email protected]>

* changes

Signed-off-by: AShivangi <[email protected]>

---------

Signed-off-by: AShivangi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants