Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Yandex search engine in the "search with" menu #217

Open
nikhil1xiz opened this issue Nov 26, 2024 · 5 comments
Open

Integration of Yandex search engine in the "search with" menu #217

nikhil1xiz opened this issue Nov 26, 2024 · 5 comments

Comments

@nikhil1xiz
Copy link

I tried integrating it myself but failed to match the styling of the icons with yandex logo, if you would be kind enough to add this minor addition in the next release it would be awesome .
Great extension overall :)

@prem-k-r
Copy link
Contributor

@XengShi are we adding it?
image

@XengShi
Copy link
Owner

XengShi commented Nov 26, 2024

@XengShi are we adding it?
image

Yess, but snowing this to non-russian counties will feel irrelevant so we can write function to show only if the userCountry is Russia (or any other countries where people use yandex) or adding toggle to show/hide in settings page.

@prem-k-r
Copy link
Contributor

@XengShi are we adding it?
image

Yess, but snowing this to non-russian counties will feel irrelevant so we can write function to show only if the userCountry is Russia (or any other countries where people use yandex) or adding toggle to show/hide in settings page.

to show only if the userCountry is Russia -- maybe this can be done since weatherAPI also returns country name when location is entered.

But adding an option in menu seems better to me, where user can select which search engines to show. And we can also add Yahoo and Baidu, alongwith Yandex. Something like multi select picklist. Toggle only for Yandex doesn't seems good idea to me.

@XengShi
Copy link
Owner

XengShi commented Nov 26, 2024

@XengShi are we adding it?
image

Yess, but snowing this to non-russian counties will feel irrelevant so we can write function to show only if the userCountry is Russia (or any other countries where people use yandex) or adding toggle to show/hide in settings page.

to show only if the userCountry is Russia -- maybe this can be done since weatherAPI also returns country name when location is entered.

But adding an option in menu seems better to me, where user can select which search engines to show. And we can also add Yahoo and Baidu, alongwith Yandex. Something like multi select picklist. Toggle only for Yandex doesn't seems good idea to me.

Yess this would be great, you can contact the person who added the ability to edit and add more shortcuts. A similar UI would be nice for 'search engines'

@nikhil1xiz
Copy link
Author

@XengShi are we adding it?
image

Yess, but snowing this to non-russian counties will feel irrelevant so we can write function to show only if the userCountry is Russia (or any other countries where people use yandex) or adding toggle to show/hide in settings page.

to show only if the userCountry is Russia -- maybe this can be done since weatherAPI also returns country name when location is entered.
But adding an option in menu seems better to me, where user can select which search engines to show. And we can also add Yahoo and Baidu, alongwith Yandex. Something like multi select picklist. Toggle only for Yandex doesn't seems good idea to me.

Yess this would be great, you can contact the person who added the ability to edit and add more shortcuts. A similar UI would be nice for 'search engines'

This would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants