Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons for choosing search engines aren't clickable outside of a checkbox input #134

Closed
ceskyDJ opened this issue Nov 3, 2024 · 9 comments

Comments

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Nov 3, 2024

If I click elsewhere than the checkbox input's circle of the search engine select section, the button doesn't react to my click. It should be more responsive, so it reacts anywhere on my clicks.

See the video for a detailed understanding:
https://www.awesomescreenshot.com/video/33214102?key=cbde51a6e8b43630d2c9c678313aef96

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 4, 2024

#138 implemented

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 5, 2024

Merged, please close

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 5, 2024

I've tried it, and it is working. One thing that needs to be fixed is that it doesn't change a mouse cursor on the hover effect (like the checkbox input circle does). It may not be very clear to some users. I'd add a cursor: pointer; to the whole button.

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 5, 2024

Please add it if you can, otherwise, I can check it tomorrow.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 5, 2024

@prem-k-r, could you please add it? I don't have so much time for it. You can add a Closes #134 to the issue description (as I noted in #133); it'll close this after merging the pull request.

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 5, 2024

Okay

@itz-rj-here
Copy link
Contributor

I've tried it, and it is working. One thing that needs to be fixed is that it doesn't change a mouse cursor on the hover effect (like the checkbox input circle does). It may not be very clear to some users. I'd add a cursor: pointer; to the whole button.

I will do that later.

@prem-k-r
Copy link
Contributor

prem-k-r commented Nov 6, 2024

Closes #134
I understand now automatic closure. I'll do it from now on.

Please close this issue as completed manually @ceskyDJ @XengShi

@XengShi XengShi closed this as completed Nov 6, 2024
@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Nov 6, 2024

You can add a Closes #134 to the issue description (as I noted in #133); it'll close this after merging the pull request.

Oh, I'm so sorry for confusion. I don't know what I have swapped it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants